module_utils_service: Fix glob path of rc.d for SUSE

[alxgu]

SUMMARY

The service module reports always a changed message when you set "enabled: true" for a service e.g. ntp.

FIX:
SUSE has the rc%.d directories under /etc/init.d
Set the glob path to /etc/init.d on SLES.

Quote of /etc/rc.d.README on SLES11.

"Some people expect the system startup scripts in /etc/rc.d/.
We use a slightly different structure for better LSB compliance."

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

module_utils/service.py

ANSIBLE VERSION

ansible 2.7.0.dev0 (service_utils_sysv f8a64807dc) last updated 2018/07/19 12:37:40 (GMT +000)

ADDITIONAL INFORMATION

OS / ENVIRONMENT

SLES11

before:
srv1~] :)$ chkconfig ntp
ntp  on
srv0: ansible -m service -a "name=ntp enabled=true" srv1 -b -D

srv1| SUCCESS => {
    "changed": true,
    "name": "ntp",
    "status": {
        "enabled": {
            "changed": true,
            "rc": 0,
            "stderr": "",
            "stdout": ""
        },
        "null": {
            "changed": false,
            "rc": null,
            "stderr": null,
            "stdout": null
        }
    }
}

after:
srv1~] :)$ chkconfig ntp
srv0: ansible -m service -a "name=ntp enabled=true" srv1 -b -D
srv1| SUCCESS => {
    "changed": false,
    "name": "ntp",
    "status": {
        "enabled": {
            "changed": false,
            "rc": null,
            "stderr": null,
            "stdout": null
        },
        "null": {
            "changed": false,
            "rc": null,
            "stderr": null,
            "stdout": null
        }
    }
}

[ansibot]

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/module_utils/service.py:52:14: E111 indentation is not a multiple of four

click here for bot help

[samdoran]

cc @bcoca

[bcoca]

actually, for old suse this might not work and others that derive from suse might have same issue, lets use it as a fallback location in general

[alxgu]

SLES11 is "oldest" supported version. SLES10 has python2.4 - ansible will exit immediately with

SyntaxError: future feature absolute_import is not defined

Should I change the commit like:

if not os.path.isdir('/etc/rc0.d/'):
    return bool(glob.glob('/etc/init.d/rc?.d/S??%s' % name))

[bcoca]

/me hides his sles8 box

Still, for other derivatives, it would still be better to not gate it specifically to 'SUSE' dist

[alxgu]

@bcoca Changed to a more generic fix

[alxgu]

shipit

[samdoran]

@alxgu Please create a changelog fragment. See fragments for examples.

[alxgu]

@samdoran done

[samdoran]

Please create a backport PR for this to be included in previous versions.