Eos subnet overlap fix #43023
Merged
Eos subnet overlap fix #43023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.7
samdoran
removed
the
needs_triage
achinthagunasekara
approved these changes
Jul 19, 2018
justjais
approved these changes
Jul 20, 2018
| @@ -341,7 +341,11 @@ def load_config(self, config, commit=False, replace=False): | |||
| commands = ['configure session %s' % session, 'abort'] | |||
| self.send_request(commands) | |||
| err = response['error'] | |||
| self._module.fail_json(msg=err['message'], code=err['code']) | |||
| error_text = [] | |||
| for data in err['data']: | |||
There was a problem hiding this comment.
Nate, here err['data'] will always return a List right?
There was a problem hiding this comment.
As far as I can tell, data has one entry per command, which should mean a minimum of two, as we start with configure session ....
Qalthos
added a commit
to Qalthos/ansible
that referenced
this pull request
Jul 20, 2018
* Detect overlapping subnet & provide better errors (cherry picked from commit dba9754)
Qalthos
added a commit
to Qalthos/ansible
that referenced
this pull request
Jul 20, 2018
* Detect overlapping subnet & provide better errors (cherry picked from commit dba9754)
nitzmahone
pushed a commit
that referenced
this pull request
Jul 23, 2018
mattclay
pushed a commit
that referenced
this pull request
Jul 27, 2018
* Detect overlapping subnet & provide better errors (cherry picked from commit dba9754)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #40187
Plus an unrelated fix for the check mode check
ISSUE TYPE
COMPONENT NAME
eos
ANSIBLE VERSION