[aws] Add suboptions to aws_application_scaling_policy #43042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.7
samdoran
removed
the
needs_triage
s-hertel
reviewed
Jul 20, 2018
| target_tracking_scaling_policy_configuration=dict( | ||
| required=False, | ||
| type='dict', | ||
| options=dict( |
There was a problem hiding this comment.
This fixes problem for me but could maybe use checking that these options are not None now that the argspec may set unwanted defaults.
The full traceback is:
Traceback (most recent call last):
File "/var/folders/by/k8_fbl593dlctgqmwq5wzl2c0000gn/T/ansible_XpZlS8/ansible_module_aws_application_scaling_policy.py", line 423, in create_scaling_policy
TargetTrackingScalingPolicyConfiguration=scaling_policy['TargetTrackingScalingPolicyConfiguration']
File "/Users/shertel/Workspace/ansible/venv/python2.7.13/lib/python2.7/site-packages/botocore/client.py", line 314, in _api_call
return self._make_api_call(operation_name, kwargs)
File "/Users/shertel/Workspace/ansible/venv/python2.7.13/lib/python2.7/site-packages/botocore/client.py", line 586, in _make_api_call
api_params, operation_model, context=request_context)
File "/Users/shertel/Workspace/ansible/venv/python2.7.13/lib/python2.7/site-packages/botocore/client.py", line 621, in _convert_to_request_dict
api_params, operation_model)
File "/Users/shertel/Workspace/ansible/venv/python2.7.13/lib/python2.7/site-packages/botocore/validate.py", line 291, in serialize_to_request
raise ParamValidationError(report=report.generate_report())
ParamValidationError: Parameter validation failed:
Invalid type for parameter TargetTrackingScalingPolicyConfiguration.CustomizedMetricSpecification, value: None, type: <type 'NoneType'>, valid types: <type 'dict'>
There was a problem hiding this comment.
Good catch. I'll take another crack at this.
ansibot
added
the
stale_ci
ansibot
removed
the
stale_ci
s-hertel
approved these changes
Sep 5, 2018
ryansb
added a commit
to ryansb/ansible
that referenced
this pull request
Sep 5, 2018
* [aws] Add suboptions to aws_application_scaling_policy Fixes ansible#42917 * Remove any suboptions that are None (cherry picked from commit 9d1bf32)
abadger
pushed a commit
that referenced
this pull request
Sep 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
For target policy, options filled in by jinja2 were loaded as strings and not converted to integers before being passed to the scaling policy API. This change adds suboptions to enforce int types on API params requiring integers.
Fixes #42917
ISSUE TYPE
COMPONENT NAME
aws_application_scaling_policy
ANSIBLE VERSION
ADDITIONAL INFORMATION