Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nxos_facts module and nxos cliconf fix stable-2.6 #43180

Merged
merged 6 commits into from
Jul 27, 2018
Merged

nxos_facts module and nxos cliconf fix stable-2.6 #43180

merged 6 commits into from
Jul 27, 2018

Conversation

trishnaguha
Copy link
Member

SUMMARY

nxos_facts module and nxos cliconf fix stable-2.6

ISSUE TYPE
  • Bugfix Pull Request

trishnaguha and others added 6 commits July 24, 2018 11:02
@trishnaguha
Refactor nxos cliconf get_device_info and add requirements for JSON s…
01c109e 
…tructured output support in nxos_facts module (ansible#42089)

* nxos_facts requires JSON structured output support

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* refactor get_device_info for legacy devices

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* update additional logic

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 0e05425)
@trishnaguha
fix regex cliconf nxos (ansible#42288)
4d41806 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit df8ad8e)
@trishnaguha
get_device_info nxos zero or more whitespace regex (ansible#43178)
a46f008 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit dd6ef33)
@trishnaguha
warning message improved (ansible#42969)
f013999 
(cherry picked from commit bea8e02)
@trishnaguha
Add text output along with structured output in nxos_facts (ansible#4…
f384b8e 
…2886)

* nxos_facts to use default output instead of structured output

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix shippable error

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* nxos_facts refactor

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add structured output back

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 1d5f881)
@trishnaguha
changelog
6ec049f 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@trishnaguha
Copy link
Member Author

cc @mattclay

@ansibot
Copy link
Contributor

ansibot commented Jul 24, 2018

cc @GGabriele @Qalthos @ganeshrn @gdpak @gundalow @jedelman8 @mikewiebe @privateip @rahushen @rcarrillocruz @tstoner
click here for bot help

@ansibot ansibot added affects_2.6 This issue/PR affects Ansible v2.6 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Jul 24, 2018
@trishnaguha trishnaguha removed the needs_triage Needs a first human triage before being processed. label Jul 24, 2018
@mattclay mattclay merged commit 171c6fc into ansible:stable-2.6 Jul 27, 2018
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@mattclay mattclay

Labels
affects_2.6 This issue/PR affects Ansible v2.6 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@trishnaguha @ansibot @dagwieers @mattclay