vault: check dir value before passing #43184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.7
mkrizek
removed
the
needs_triage
mkrizek
reviewed
Jul 24, 2018
| @@ -927,7 +927,7 @@ def create_file(self, filename, secret, vault_id=None): | |||
| """ create a new encrypted file """ | |||
|
|
|||
| dirname = os.path.dirname(filename) | |||
| if not os.path.exists(dirname): | |||
| if dirname != '' and not os.path.exists(dirname): | |||
There was a problem hiding this comment.
Can we do if dirname and not os.path.exists(dirname): instead? Looks nicer I think.
This fix checks if dirname is not equal to '' before proceeding to create actual directory with name. Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Akasurde
force-pushed
the
vault_minor_fix
branch
from
f960d02
to
2de9b0d
Compare
ansibot
removed
the
needs_revision
|
@mkrizek Can you please take another look ? |
mkrizek
approved these changes
Jul 24, 2018
|
@mkrizek Thanks for the review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This fix checks if dirname is not equal to '' before proceeding
to create actual directory with name.
Before fix -
After fix -
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
ISSUE TYPE
COMPONENT NAME
lib/ansible/parsing/vault/init.py
ANSIBLE VERSION