vultr.py: query_resource_by_key Handle list and dict #43301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.7
samdoran
removed
the
needs_triage
Spredzy
force-pushed
the
handle_list_and_array
branch
from
a49a0c4
to
41f1ae0
Compare
ansibot
added
the
stale_ci
The Vultr API is inconsistent in the type of the value it returns based on the resources. While most of the time it will be a dict, for some resources it will be a list (/v1/user/list, /v1/block/list). query_resource_by_key() fails if the return value isn't a dict (.items() does not exist on list). This patch aims to support both list and dict.
Spredzy
force-pushed
the
handle_list_and_array
branch
from
41f1ae0
to
8962f6a
Compare
ansibot
removed
the
stale_ci
|
bot_status |
Componentslib/ansible/module_utils/vultr.py Metadatawaiting_on: ansible |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The Vultr API is inconsistent in the type of the value it returns
based on the resources. While most of the time it will be a dict, for
some resources it will be a list (
/v1/user/list,/v1/block/list).query_resource_by_key()fails if the return value isn't a dict (.items()does not exist on list). This patch aims to support both list and dict.
ISSUE TYPE
COMPONENT NAME
ANSIBLE VERSION
ADDITIONAL INFORMATION