Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable setting options for cliconf and other implementation plugins (if set to configurable) #43368

Merged
merged 2 commits into from
Jul 31, 2018
Merged

Enable setting options for cliconf and other implementation plugins (if set to configurable) #43368

merged 2 commits into from
Jul 31, 2018

Conversation

ganeshrn
Copy link
Member

@ganeshrn ganeshrn commented Jul 27, 2018 •
edited

SUMMARY

Fixes #43367

  • Add support to set configuration options for implementation plugins (eg: cliconf)
    from ansible-connection. This also enables setting configuration options in eos cliconf plugins
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

bin/ansible-connection
plugins/connection/init.py

ANSIBLE VERSION
2.7
ADDITIONAL INFORMATION

@ganeshrn
Enable setting setting cliconf plugin options
599d5ff 
Fixes ansible#43367

* Add support to set configuration options for implementation plugins (eg: cliconf)
  from `ansible-connection`
@ganeshrn ganeshrn requested a review from Qalthos July 27, 2018 20:33
@ganeshrn ganeshrn changed the title Enable setting cliconf plugin options Enable setting cliconf plugin options and other implementation plugins if configurable Jul 27, 2018
@ganeshrn ganeshrn changed the title Enable setting cliconf plugin options and other implementation plugins if configurable Enable setting options for cliconf and other implementation plugins (if set to configurable) Jul 27, 2018
@ansibot
Copy link
Contributor

ansibot commented Jul 27, 2018

cc @Qalthos @gdpak @gundalow @privateip @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Jul 27, 2018
@ganeshrn ganeshrn removed the needs_triage Needs a first human triage before being processed. label Jul 27, 2018
@ansibot ansibot added the bug This issue/PR relates to a bug. label Jul 27, 2018
@ansibot
Copy link
Contributor

ansibot commented Jul 27, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/plugins/connection/__init__.py:350:5: E303 too many blank lines (2)

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 27, 2018
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 28, 2018
@ganeshrn ganeshrn merged commit ea6ef3f into ansible:devel Jul 31, 2018
@ganeshrn ganeshrn deleted the eos_cliconf_options branch July 31, 2018 04:53
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Qalthos Qalthos Qalthos approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. feature This issue/PR relates to a feature request. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eos_config fails to disable configure session
3 participants
@ganeshrn @ansibot @Qalthos