Have nsupdate add expected quotation to TXT records #43386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.7
|
The test |
ansibot
added
ci_verified
This prevents the accidental creation of TXT records where every single word gets split into its own string, such as TXT record values in the format of `"foo" "bar" "baz"`. That being an implicit behavior I have very hard to see anyone purposely relying on. TXT record values can still explicitly be defined as one or more strings, without any change in syntax. Resolves ansible#43380
andreaso
force-pushed
the
nsupdate-helpful-txt-quoting
branch
from
e598596
to
978f85b
Compare
ansibot
added
community_review
Nothing4You
reviewed
Jul 28, 2018
| @@ -207,8 +207,18 @@ def __init__(self, module): | |||
| else: | |||
| self.algorithm = module.params['key_algorithm'] | |||
|
|
|||
| if self.module.params['type'].lower() == 'txt': | |||
There was a problem hiding this comment.
This issue also affects SPF records (even though they are deprecated).
Maybe there are other record types aswell that use text values?
There was a problem hiding this comment.
This is strictly a personal opinion, but I don't really feel inclined to add code to support a deprecated record type.
ryansb
removed
the
needs_triage
|
@nerzhul: Thoughts? |
ansibot
added
the
stale_ci
|
One week remaining until the Ansible 2.7 community modules freeze. @nerzhul: Any opinion either way in regards to this PR? |
|
shipit |
ansibot
added
shipit
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This prevents the accidental creation of TXT records where every
single word gets split into its own string, such as TXT record values
in the format of
"foo" "bar" "baz". That being an implicit behaviorI have very hard to see anyone purposely relying on.
TXT record values can still explicitly be defined as one or more
strings, without any change in syntax.
Resolves #43380
ISSUE TYPE
COMPONENT NAME
nsupdate
ANSIBLE VERSION