Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware: provide appropriate error if NICs missing #43414

Merged
merged 1 commit into from
Jul 30, 2018
Merged

VMware: provide appropriate error if NICs missing #43414

merged 1 commit into from
Jul 30, 2018

Conversation

Akasurde
Copy link
Member

SUMMARY

While creating/reconfiguring vSwitch without NICs check if nics details
are gathered or not.

Fixes: #42619

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/vmware/vmware_vswitch.py

ANSIBLE VERSION
2.7-devel

@Akasurde
VMware: provide appropriate error if NICs missing
7ab62b1 
While creating/reconfiguring vSwitch without NICs check if nics details
are gathered or not.

Fixes: ansible#42619

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot
Copy link
Contributor

ansibot commented Jul 30, 2018

cc @dav1x @warthog9
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Jul 30, 2018
@Akasurde Akasurde mentioned this pull request Jul 30, 2018
Closed
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Jul 30, 2018
@Akasurde
Copy link
Member Author

@dericcrago @pdellaert Could you please review this ?

pdellaert
pdellaert approved these changes Jul 30, 2018
View reviewed changes
Copy link
Contributor

@pdellaert pdellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jul 30, 2018
@ansibot ansibot merged commit 80369cf into ansible:devel Jul 30, 2018
@Straevaras
Copy link

I applied this PR manually and am noticing I'm not able to update the MTU of a vSwitch if it doesn't have any NICs listed.

@Akasurde Akasurde deleted the i42619 branch August 8, 2018 11:45
@Akasurde
Copy link
Member Author

Akasurde commented Aug 8, 2018

@Straevaras Yes, you need to have NIC present to modify MTU.

@Straevaras Straevaras mentioned this pull request Aug 8, 2018
Closed
@nicholasrodriguez
Copy link

I experienced the same issue as in #42619. I've manually updated the fix above and it now works on ESXi 6.7.
Thanks @Akasurde

@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pdellaert pdellaert pdellaert approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vmware_switch fails add vswitch without vNICs
5 participants
@Akasurde @ansibot @Straevaras @nicholasrodriguez @pdellaert