httpapi: let httpapi plugin handle HTTPErrors other than 401

[Qalthos]

SUMMARY

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

httpapi

ANSIBLE VERSION

2.7

[ansibot]

The test ansible-test sanity --test pylint [explain] failed with 4 errors:

lib/ansible/plugins/httpapi/eos.py:37:18: undefined-variable Undefined variable 'AnsibleConnectionFailure'
lib/ansible/plugins/httpapi/eos.py:38:55: undefined-variable Undefined variable 'exc'
lib/ansible/plugins/httpapi/nxos.py:34:18: undefined-variable Undefined variable 'AnsibleConnectionFailure'
lib/ansible/plugins/httpapi/nxos.py:35:47: undefined-variable Undefined variable 'exc'

click here for bot help

[gdpak]

This might fail on python 3 and json.loads expects string and getvalue() will return bytes .

[Qalthos]

On 3.5, yeah... I'll fix that

[gdpak]

A bit off topic. Can you please also take care of below small change otherwise it is modifying headers passed to send() .

@@ -243,7 +243,9 @@ class Connection(NetworkConnectionBase):
         )
         url_kwargs.update(kwargs)
         if self._auth:
-            url_kwargs['headers'].update(self._auth)
+            headers = dict(url_kwargs['headers'])
+            headers.update(self._auth)
+            url_kwargs['headers'] = headers
         else:

[Qalthos]

The last commit can stay or go... it does add a bit of complexity, but it also means that the whole business of dealing with HTTP status codes is customizable in a flexible way.

Edit: by 'The last commit', I am now referring to the commit following this comment, as it needed an edit.

[gdpak]

@Qalthos In case we were downloading big file then we were seeing update_auth() crash while trying to json.loads of response_data. so one idea was to not look at response_data in each sent request. so we update auth data inside http_plugin
CiscoDevNet/FTDAnsible@54ea3cb

with this, we don't need to read response in update_auth. So if you wish we can convert logic to send only response from send() like earlier and client can do read() or chunk read whatever they wish to ?