Fail module if configure replace fails nxos #43546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.7
ansibot
added
networking
trishnaguha
changed the title
trishnaguha
force-pushed
the
nxos_terminal_plugin
branch
2 times, most recently
from
dc0f1d0
to
c132807
Compare
Qalthos
reviewed
Aug 1, 2018
lib/ansible/plugins/terminal/nxos.py
Outdated
| @@ -48,7 +48,8 @@ class TerminalModule(TerminalBase): | |||
| re.compile(br"unknown command"), | |||
| re.compile(br"user not present"), | |||
| re.compile(br"invalid (.+?)at '\^' marker", re.I), | |||
| re.compile(br"baud rate of console should be (\d*) to increase severity level", re.I) | |||
| re.compile(br"baud rate of console should be (\d*) to increase severity level", re.I), | |||
| re.compile(br"Configure replace failed", re.I) | |||
There was a problem hiding this comment.
I'd like to see a trailing comma here, just to keep future changes smaller
ansibot
removed
the
needs_triage
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
trishnaguha
force-pushed
the
nxos_terminal_plugin
branch
from
c132807
to
482099f
Compare
Qalthos
approved these changes
Aug 1, 2018
trishnaguha
added a commit
to trishnaguha/ansible
that referenced
this pull request
Aug 8, 2018
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
|
reverted by #43806 |
trishnaguha
added a commit
to trishnaguha/ansible
that referenced
this pull request
Aug 8, 2018
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
alikins
added a commit
that referenced
this pull request
Aug 8, 2018
* devel: (177 commits) Fix all ACI examples to use delegate_to (#43439) Ensure removed_in is StrictVersion before comparing (#43835) Network *_config action plugin updates (#43838) Lenovo size reduce cnos.py of util (#43823) Add OpenStack Magnum cluster template module (#42654) Correct task args in azure_rm_managed_disk test. Fix PEP 8 issue in exos_facts. Add os_listener module for OpenStack Octavia (#42604) Add os_loadbalancer module for OpenStack Octavia service (#42552) network/exos: add exos_facts module (#43210) Added junos_config note about override set format (#43608) New networking module: voss_command (#43741) make lockfile destination settable and update doc (#42795) VMware: Update example (#43786) Update eos clcionf plugin (#43809) refine aks document (#43810) revert #43546 nxos terminal plugin (#43806) improve 'service' integration tests (#43655) Fix nsg cannot add rule with purge_rules false (#43699) add azure_rm_appserviceplan module (#40906) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Trishna Guha trishnaguha17@gmail.com
SUMMARY
ISSUE TYPE
COMPONENT NAME
plugins/terminal/nxos.py
ANSIBLE VERSION