Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ldap_entry bugfix #43620

Merged
merged 2 commits into from
Aug 6, 2018
Merged

ldap_entry bugfix #43620

merged 2 commits into from
Aug 6, 2018

Conversation

gustavomcarmo
Copy link
Contributor

SUMMARY

Fixes the same issue reported in #39569, but for the ldap_entry module.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ldap_entry

ANSIBLE VERSION
2.6

@ansibot
Copy link
Contributor

ansibot commented Aug 2, 2018

cc @jtyr
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. net_tools Net-tools category small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Aug 2, 2018
jtyr
jtyr suggested changes Aug 2, 2018
View reviewed changes
lib/ansible/modules/net_tools/ldap/ldap_entry.py Outdated
@@ -145,9 +145,9 @@ def _load_attrs(self):
attrs[name] = []

if isinstance(value, list):
attrs[name] = value
attrs[name] = [to_bytes(v) for v in value]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you use map(to_bytes, value) instead of the for loop?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Aug 2, 2018
@jtyr
Copy link
Contributor

jtyr commented Aug 3, 2018

Thanks for your PR, @gustavomcarmo.

@ansibot please shipit.

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 3, 2018
@gustavomcarmo
Copy link
Contributor Author

@Akasurde could you please review this PR and merge it?

@Akasurde
Copy link
Member

Akasurde commented Aug 6, 2018

Closing and re-opening for CI trigger.

@Akasurde Akasurde closed this Aug 6, 2018
@Akasurde Akasurde reopened this Aug 6, 2018
@Akasurde Akasurde merged commit d971dd2 into ansible:devel Aug 6, 2018
@gustavomcarmo gustavomcarmo deleted the ldap_entry_bugfix branch August 7, 2018 13:09
@jtyr jtyr mentioned this pull request Sep 15, 2018
Closed
@Saloshp
Copy link

Saloshp commented Sep 17, 2018

The fix does not resolve the bug, see updated traceback #45417

@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jtyr jtyr jtyr approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. net_tools Net-tools category support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gustavomcarmo @ansibot @jtyr @Akasurde @Saloshp