Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add external provider to ovirt network #43636

Merged
merged 8 commits into from
Oct 4, 2018
Merged

add external provider to ovirt network #43636

merged 8 commits into from
Oct 4, 2018

Conversation

mnecas
Copy link
Contributor

@mnecas mnecas commented Aug 3, 2018 •
edited

SUMMARY

#42895

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ovirt

ANSIBLE VERSION
ansible 2.6.2
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/mnecas/Desktop/Projects/Redhat/ansible/lib/ansible/modules/cloud/ovirt']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.15 (default, May 16 2018, 17:50:09) [GCC 8.1.1 20180502 (Red Hat 8.1.1-1)]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Aug 3, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/ovirt/ovirt_networks.py:0:0: E309 version_added for new option (external_provider) should be 2.7. Currently 0.0

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 3, 2018

cc @machacekondra @mwperina
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 ci_verified Changes made in this PR are causing tests to fail. cloud feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) support:community This issue/PR relates to code supported by the Ansible community. labels Aug 3, 2018
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Aug 3, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 3, 2018
jamescassell
jamescassell approved these changes Aug 3, 2018
View reviewed changes
Copy link
Contributor

@jamescassell jamescassell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an example?

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 11, 2018
@mnecas
Copy link
Contributor Author

mnecas commented Aug 13, 2018

I still got one error in engine so don't merge yet I'll open another issue.

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 13, 2018
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed new_contributor This PR is the first contribution by a new community member. labels Aug 21, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 27, 2018

@mnecas this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 27, 2018
@mnecas mnecas force-pushed the ovirt_add_external_provider branch from e8342a5 to 9bb0253 Compare August 27, 2018 14:27
@ansibot ansibot removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Aug 27, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 17, 2018

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/cloud/ovirt/ovirt_network.py:104:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/ovirt/ovirt_network.py:110:1: W293 blank line contains whitespace

click here for bot help

@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Sep 17, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 17, 2018
machacekondra
machacekondra approved these changes Sep 19, 2018
View reviewed changes
Copy link
Contributor

@machacekondra machacekondra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels Sep 19, 2018
mwperina
mwperina approved these changes Sep 19, 2018
View reviewed changes
Copy link
Contributor

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@machacekondra
Copy link
Contributor

shipit

@ansibot ansibot added support:community This issue/PR relates to code supported by the Ansible community. automerge This PR was automatically merged by ansibot. and removed support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 4, 2018
@ansibot ansibot merged commit d79be6a into ansible:devel Oct 4, 2018
@machacekondra machacekondra mentioned this pull request Dec 7, 2018
Closed
@dagwieers dagwieers added ovirt oVirt and RHV community and removed virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) labels Feb 21, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@machacekondra machacekondra machacekondra approved these changes

@jamescassell jamescassell jamescassell approved these changes

@mwperina mwperina mwperina approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 automerge This PR was automatically merged by ansibot. cloud feature This issue/PR relates to a feature request. module This issue/PR relates to a module. ovirt oVirt and RHV community shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mnecas @ansibot @machacekondra @jamescassell @mwperina @dagwieers @mkrizek