Docker version check error #43639

bitozoid · 2018-08-03T12:36:38Z

SUMMARY

Docker component is querying version the wrong way. The component asks for:

$ docker version --format "'{{.Server.Version}}'"
'dev'

but IMHO should ask for:

$ docker version --format "'{{.Server.APIVersion}}'"
'1.37'

ansible/lib/ansible/plugins/connection/docker.py

Line 139 in 32c0164

new_version_subcommand = ['version', '--format', "'{{.Server.Version}}'"]

ISSUE TYPE

Bug Report

COMPONENT NAME

plugins/connection/docker.py

ANSIBLE VERSION

ansible 2.6.2
  config file = /home/bitozoid/.ansible.cfg
  configured module search path = ['/home/eduardo/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']                                                                            
  ansible python module location = /usr/local/virtual/python/virtualenv/ansible/lib/python3.6/site-packages/ansible                                                                           
  executable location = /usr/local/virtual/python/virtualenv/ansible/bin/ansible
  python version = 3.6.5 (default, Apr  3 2018, 10:42:08) [GCC 7.3.0]

CONFIGURATION

DEFAULT_ROLES_PATH(/home/bitozoid/.ansible.cfg) = ['/home/bitozoid/grow/setup/ansible/roles']
DEFAULT_VAULT_PASSWORD_FILE(env: ANSIBLE_VAULT_PASSWORD_FILE) = /home/bitozoid/.vaults/test.txt
RETRY_FILES_ENABLED(/home/bitozoid/.ansible.cfg) = False

OS / ENVIRONMENT

$ cat /etc/os-release
NAME="Exherbo"
PRETTY_NAME="Exherbo Linux"
ID="exherbo"
ANSI_COLOR="0;32"
HOME_URL="https://www.exherbo.org/"
SUPPORT_URL="irc://irc.freenode.net/#exherbo"
BUG_REPORT_URL="https://bugs.exherbo.org/"

$ docker version
Client:
 Version:      18.05.0-ce
 API version:  1.37
 Go version:   go1.10.3
 Git commit:   18.05.0-ce
 Built:        Fri Aug  3 12:13:56 2018
 OS/Arch:      linux/amd64
 Experimental: false
 Orchestrator: swarm

Server:
 Engine:
  Version:      dev
  API version:  1.37 (minimum version 1.12)
  Go version:   go1.10.3
  Git commit:   18.05.0-ce
  Built:        Mon Jun 25 12:33:52 2018
  OS/Arch:      linux/amd64
  Experimental: false

STEPS TO REPRODUCE

Just use a docker image as driver for molecule. May paste the hole project if needed.

EXPECTED RESULTS

No error.

ACTUAL RESULTS

    TASK [Install EPEL repository for lighttpd] ************************************
    task path: /home/bitozoid/grow/setup/ansible/roles/ansible-dokuwiki/molecule/docker/prepare.yml:6
    The full traceback is:
    Traceback (most recent call last):
      File "/usr/local/virtual/python/virtualenv/ansible/lib/python3.6/site-packages/ansible/executor/task_executor.py", line 138, in run
        res = self._execute()
      File "/usr/local/virtual/python/virtualenv/ansible/lib/python3.6/site-packages/ansible/executor/task_executor.py", line 522, in _execute
        self._connection = self._get_connection(variables=variables, templar=templar)
      File "/usr/local/virtual/python/virtualenv/ansible/lib/python3.6/site-packages/ansible/executor/task_executor.py", line 808, in _get_connection
        ansible_playbook_pid=to_text(os.getppid())
      File "/usr/local/virtual/python/virtualenv/ansible/lib/python3.6/site-packages/ansible/plugins/loader.py", line 397, in get
        obj = obj(*args, **kwargs)
      File "/usr/local/virtual/python/virtualenv/ansible/lib/python3.6/site-packages/ansible/plugins/connection/docker.py", line 92, in __init__
        if LooseVersion(docker_version) < LooseVersion(u'1.3'):
      File "/usr/lib/python3.6/distutils/version.py", line 52, in __lt__
        c = self._cmp(other)
      File "/usr/lib/python3.6/distutils/version.py", line 337, in _cmp
        if self.version < other.version:
    TypeError: '<' not supported between instances of 'str' and 'int'

    fatal: [ddokuwiki]: FAILED! => {
        "msg": "Unexpected failure during module execution.",
        "stdout": ""
    }

The text was updated successfully, but these errors were encountered:

ansibot · 2018-08-03T12:43:29Z

Files identified in the description:

lib/ansible/modules/cloud/docker/_docker.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

ansibot · 2018-08-03T12:43:30Z

cc @ThomasSteinbach @cove @dusdanig @joshuaconner @softzilla @zfil
click here for bot help

ansibot · 2018-10-06T16:31:55Z

cc @felixfontein
click here for bot help

felixfontein · 2018-10-06T20:53:36Z

!component =lib/ansible/plugins/connection/docker.py

felixfontein · 2018-10-06T20:56:21Z

I think it is querying the correct version. It doesn't know about the "dev" version, though. Do you use a custom build of the Docker server, or a development version?

Usually, installed versions output something else, like '18.06.1-ce'. And that can be parsed correctly.

If 'dev' is returned by the development version, we could include some logic which detects it and treats it as "new enough".

ansibot · 2018-10-06T21:03:28Z

Files identified in the description:

lib/ansible/plugins/connection/docker.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

ansibot · 2018-10-06T21:03:28Z

cc @dariko @jwitko @kassiansun @tbouvet
click here for bot help

bitozoid · 2018-10-09T14:23:36Z

Docker installation comes from the following recipe (for Exherbo Linux, similar to bash syntax):

https://git.exherbo.org/virtualization.git/tree/packages/app-virtualization/moby/moby-18.06.1.exheres-0

I guess version name comes from the VERSION file:

https://github.com/docker/docker-ce/commits/master/VERSION

However the v18.06.1-ce tag has no dev in it:

https://github.com/docker/docker-ce/blob/v18.06.1-ce/VERSION

bitozoid · 2018-10-10T07:18:12Z

It may be a problem with the recipe to build docker. It is using the function docker_make:

https://git.exherbo.org/virtualization.git/tree/packages/app-virtualization/moby/moby-18.06.1.exheres-0#n67

which calls the build script directly.

https://github.com/docker/docker-ce/blob/e68fc7a215d7133c34aa18e3b72b4a21fd0c6136/components/engine/hack/make.sh#L17

Then, VERSION variable is not defined and takes dev as default.

https://git.exherbo.org/virtualization.git/tree/packages/app-virtualization/moby/moby-18.06.1.exheres-0#n67

bitozoid · 2018-10-10T11:12:15Z

Fixed upstream:

https://gitlab.exherbo.org/exherbo/virtualization/merge_requests/26

felixfontein · 2018-10-12T07:22:12Z

@bitozoid Awesame! That's probably the best solution.

drewmullen · 2018-10-17T23:18:02Z

has this been baked into a release yet? the latest im seeing on https://download.docker.com/linux/debian/dists/ is 10/5. im new to docker though, not sure how exherbo/virtualization relates to the overall moby/moby project or if i can roll this into my local system ahead of time

felixfontein · 2018-10-21T12:50:04Z

@drewmullen about what releases are you speaking? Releases of docker? Regular docker releases never have dev as a version, but something meaningful which doesn't cause this problem (AFAIK).

ansibot · 2018-10-29T13:40:47Z

cc @akshay196 @danihodovic
click here for bot help

felixfontein · 2018-11-29T20:03:58Z

needs_info

ansibot · 2018-12-15T06:27:46Z

cc @DBendit
click here for bot help

ansibot · 2019-01-01T03:12:03Z

@bitozoid This issue is waiting for your response. Please respond or the issue will be closed.

click here for bot help

ansibot · 2019-02-02T03:48:32Z

@bitozoid You have not responded to information requests in this issue so we will assume it no longer affects you. If you are still interested in this, please create a new issue with the requested information.

click here for bot help

mkrizek removed the needs_triage Needs a first human triage before being processed. label Aug 3, 2018

ansibot added the needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) label Aug 27, 2018

ansibot removed the module This issue/PR relates to a module. label Oct 6, 2018

sivel mentioned this issue Oct 17, 2018

converge fails on newly init role - python 3.6.6 ansible/molecule#1514

Closed

ansibot added support:community This issue/PR relates to code supported by the Ansible community. and removed support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Nov 26, 2018

ansibot added the needs_info This issue requires further information. Please answer any outstanding questions. label Nov 29, 2018

ansibot closed this as completed Feb 2, 2019

oszi mentioned this issue May 25, 2019

The docker connection plugin fails at version checking #56946

Closed

felixfontein mentioned this issue May 25, 2019

docker conncetion plugin: accept 'dev' as 'newest version' #56947

Merged

ansible locked and limited conversation to collaborators Jul 25, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Docker version check error #43639

Docker version check error #43639

bitozoid commented Aug 3, 2018 •

edited

ansibot commented Aug 3, 2018

ansibot commented Aug 3, 2018

ansibot commented Oct 6, 2018

felixfontein commented Oct 6, 2018

felixfontein commented Oct 6, 2018

ansibot commented Oct 6, 2018

ansibot commented Oct 6, 2018

bitozoid commented Oct 9, 2018

bitozoid commented Oct 10, 2018

bitozoid commented Oct 10, 2018

felixfontein commented Oct 12, 2018

drewmullen commented Oct 17, 2018 •

edited

felixfontein commented Oct 21, 2018

ansibot commented Oct 29, 2018

felixfontein commented Nov 29, 2018

ansibot commented Dec 15, 2018

ansibot commented Jan 1, 2019

ansibot commented Feb 2, 2019

Docker version check error #43639

Docker version check error #43639

Comments

bitozoid commented Aug 3, 2018 • edited

SUMMARY

ISSUE TYPE

COMPONENT NAME

ANSIBLE VERSION

CONFIGURATION

OS / ENVIRONMENT

STEPS TO REPRODUCE

EXPECTED RESULTS

ACTUAL RESULTS

ansibot commented Aug 3, 2018

ansibot commented Aug 3, 2018

ansibot commented Oct 6, 2018

felixfontein commented Oct 6, 2018

felixfontein commented Oct 6, 2018

ansibot commented Oct 6, 2018

ansibot commented Oct 6, 2018

bitozoid commented Oct 9, 2018

bitozoid commented Oct 10, 2018

bitozoid commented Oct 10, 2018

felixfontein commented Oct 12, 2018

drewmullen commented Oct 17, 2018 • edited

felixfontein commented Oct 21, 2018

ansibot commented Oct 29, 2018

felixfontein commented Nov 29, 2018

ansibot commented Dec 15, 2018

ansibot commented Jan 1, 2019

ansibot commented Feb 2, 2019

bitozoid commented Aug 3, 2018 •

edited

drewmullen commented Oct 17, 2018 •

edited