Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for GCP Compute Instance Facts #43698

Merged
merged 1 commit into from
Aug 17, 2018
Merged

Adding support for GCP Compute Instance Facts #43698

merged 1 commit into from
Aug 17, 2018

Conversation

rambleraptor
Copy link
Contributor

SUMMARY

Adding support for GCP Compute Instance Factss

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

gcp_compute_instance_facts

ANSIBLE VERSION
2.7
ADDITIONAL INFORMATION

This was autogenerated using Magic Modules

@rambleraptor rambleraptor changed the title Adding support for GCP Compute Instance Factss Adding support for GCP Compute Instance Facts Aug 6, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 6, 2018

cc @erjohnso
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 cloud core_review In order to be merged, this PR must follow the core review workflow. gce module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 6, 2018
@rambleraptor rambleraptor force-pushed the gcp_compute_instance_facts branch 2 times, most recently from 87a7744 to 3ac659f Compare August 6, 2018 06:13
@ansibot
Copy link
Contributor

ansibot commented Aug 6, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/google/gcp_compute_instance_facts.py:544:1: E305 expected 2 blank lines after class or function definition, found 0

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/google/gcp_compute_instance_facts.py:0:0: E307 version_added should be 2.7. Currently 2.6

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 6, 2018
@ryansb ryansb removed the needs_triage Needs a first human triage before being processed. label Aug 7, 2018
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Aug 8, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 13, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 17, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 17, 2018

@GwenaelPellenArkeup @bennojoy @dohoangkhiem @erjohnso @GoogleCloudPlatform @nitaco @robwagner33 @walbert947

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ryansb ryansb merged commit 7676fb1 into ansible:devel Aug 17, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryansb ryansb ryansb approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 cloud community_review In order to be merged, this PR must follow the community review workflow. gce module This issue/PR relates to a module. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rambleraptor @ansibot @ryansb @mattclay