win_domain modules: ensure Netlogon service is still running after promotion #43703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.7
ryansb
removed
the
needs_triage
jhawkesworth
reviewed
Aug 8, 2018
| # with ansible_winrm_transport=basic so we just display a warning if | ||
| # this fails. | ||
| try { | ||
| Start-Service -Name Netlogon |
There was a problem hiding this comment.
I wonder if its worth 'treading lightly' and only calling 'Start-Service' if Netlogon isn't currently running? Would potentially avoid an unneeded warning if using Basic auth?
There was a problem hiding this comment.
Probably not, if the service is already running it shouldn't be doing anything. If an error comes up then it's probably a sign of a bigger issue and we should know about it.
jborean93
added a commit
to jborean93/ansible
that referenced
this pull request
Aug 10, 2018
…omotion (ansible#43703) (cherry picked from commit 7b1cc11)
|
Backport PR to stable-2.6 #43913 |
alikins
added a commit
that referenced
this pull request
Aug 10, 2018
* devel: (30 commits) Prevent data being truncated over persistent connection socket (#43885) Fix eos_command integration test failures (#43922) Update iosxr cliconf plugin (#43837) win_domain modules: ensure Netlogon service is still running after promotion (#43703) openvswitch_db : Handle column value conversion and idempotency in no_key case (#43869) Fix typo Fix spelling of ansbile to ansible (#43898) added platform guides for NOS and VOSS (#43854) Fix download URL for yum integration test. New module for managing EMC VNX Block storage (#42945) Docker integration tests: factorize setup (#42306) VMware: datastore selection (#35812) Remove unnecessary features from cli_command (#43829) [doc] import_role: mention version from which behavior changed and fix some typos (#43843) Add source interface and use-vrf features (#43418) Fix unreferenced msg from vmware_host (#43872) set supports_generate_diff to False vyos (#43873) add group_by_os_family in azure dynamic inventory (#40702) ansible-test: Create public key creating Windows targets (#43760) azure_rm_loadbalancer_facts.py: list() takes at least 2 arguments fix (#29046) (#29050) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When promoting a server to a domain controller, Ansible is unable to authenticate to the server unless it is manually rebooted, the
Netlogonservice is started manually, orbasicauth is used. This change tries to start theNetlogonservice manually before returning back to the host so subsequent calls likewin_rebootcan reboot the host.Fixes #39235
ISSUE TYPE
COMPONENT NAME
win_domain
win_domain_controller
ANSIBLE VERSION