cs instance root_disk size update resizes the root volume #43817

greut · 2018-08-08T09:57:55Z

SUMMARY

CloudStack's resizeVolume on the ROOT volume of a VM based on the root_disk_size.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

cloud / cloudstack / cs_instance

ANSIBLE VERSION

ansible 2.7.0.dev0 (cs-instance-root-disk-size c9a9a5d39a) last updated 2018/08/08 11:47:28 (GMT +200)
  config file = None
  configured module search path = ['/home/yoan/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /home/yoan/soft/ansible/lib/ansible
  executable location = /home/yoan/soft/ansible/venv36/bin/ansible
  python version = 3.6.6 (default, Aug  6 2018, 17:27:47) [GCC 8.2.0]

ADDITIONAL INFORMATION

Assuming, you created an instance with a root_disk_size or based on a template supporting it. Changing its value will triggers a resizeVolume call applying the changes. shrinkok is an extra option.

      cs_instance:
        template: Linux Debian 9 64-bit
        name: test
        state: present
        root_disk_size: 14
        shrinkok: true
        force: true

Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch> Reviewed-by: Marc-Aurèle Brothier <m@brothier.org>

ansibot · 2018-08-08T09:59:57Z

cc @dpassante @resmo
click here for bot help

Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>

ansibot · 2018-08-08T10:35:27Z

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/cloud/cloudstack/cs_instance.py:0:0: E309 version_added for new option (shrinkok) should be 2.7. Currently 0.0
lib/ansible/modules/cloud/cloudstack/cs_instance.py:0:0: E323 "shrinkok" is listed in DOCUMENTATION.options, but not accepted by the module

click here for bot help

Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>

marcaurele · 2018-08-08T11:20:29Z

lib/ansible/modules/cloud/cloudstack/cs_instance.py

+
+        if root_disk_size is not None:
+            res = self.query_api('listVolumes', type='ROOT', virtualmachineid=instance['id'])
+            [volume] = res['volume']


Shall we catch a just in case missing volume in the response to be cleaner?:

volume = res.get('volume') if volume: ....

defensive programming doesn't help figuring it out what's wrong, in case something is wrong.

resmo · 2018-08-09T21:26:15Z

Thanks for the contribution. code looks good to me. One thing I don't like that much is the param name shrinkok, what about allow_shrink or allow_root_disk_shrink?

marcaurele · 2018-08-10T04:43:54Z

You're right we need something more meaningful to relate to the root disk of the VM since we are in the instance module. I'd prefer the allow_root_disk_shrink or simply root_disk_shrink.

Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>

resmo · 2018-08-18T08:12:16Z

lib/ansible/modules/cloud/cloudstack/cs_instance.py

+            if shrinkok:
+                args_volume_update['shrinkok'] = shrinkok
+
+            root_disk_size_changed = root_disk_size != size


one more question, this would also be "true" for enlargement of the disk, would this work as expected? if yes, allow_root_disk_shrink would be a misleading name because it would not only resize to smaller, but also resize to bigger volume --> allow_root_disk_resize

it's really only for _shrinkagethat a special flag needs to be sent.allow_root_disk_resize` would be misleading as the nothing special is required for enlarging a disk.

http://cloudstack.apache.org/api/apidocs-4.4/user/resizeVolume.html

@resmo the shrink option is only for changing the disk size to a smaller partition. It requires more actions from the user if it should success:

https://github.com/apache/cloudstack/blob/756a7e89cbcec7a1aa98b3f470cbdf8181af75ad/server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java#L1022

http://libguestfs.org/virt-resize.1.html (section "SHRINKING A VIRTUAL MACHINE DISK")

so, that means, we should change this condition to the following, right?

root_disk_size_changed = root_disk_size < size

No, you can resize the volume up or down, but if you want to resize it down you must specify the flag shrink to ensure you know what you are doing since it requires some preparation of the volume.

ok, got it! 👍

resmo

needs_info

resmo · 2018-08-28T13:52:50Z

rebuild_merge

resmo · 2018-08-28T14:20:10Z

bot_status

ansibot · 2018-08-28T14:55:48Z

Components

lib/ansible/modules/cloud/cloudstack/cs_instance.py
support: community
maintainers: dpassante resmo

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainer or core team member): []
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

resmo · 2018-08-28T15:02:42Z

rebuild_merge

cloudstack: resize volume on root_disk_size changes

8ce3f57

Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch> Reviewed-by: Marc-Aurèle Brothier <m@brothier.org>

greut changed the title ~~Cs instance root disk size~~ cs instance root_disk size update resizes the root volume Aug 8, 2018

fixup! cloudstack: resize volume on root_disk_size changes

b8b255a

Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>

ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 8, 2018

fixup! fixup! cloudstack: resize volume on root_disk_size changes

d70808c

Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>

ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Aug 8, 2018

marcaurele reviewed Aug 8, 2018

View reviewed changes

ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 8, 2018

jborean93 removed the needs_triage Needs a first human triage before being processed. label Aug 9, 2018

cs_instance: rename flag to allow_root_disk_shrink

29b7d81

Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>

resmo reviewed Aug 18, 2018

View reviewed changes

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 18, 2018

ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 28, 2018

ansibot merged commit cf61510 into ansible:devel Aug 28, 2018

greut deleted the cs-instance-root-disk-size branch December 5, 2018 14:41

ansible locked and limited conversation to collaborators Jul 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cs instance root_disk size update resizes the root volume #43817

cs instance root_disk size update resizes the root volume #43817

greut commented Aug 8, 2018

ansibot commented Aug 8, 2018

ansibot commented Aug 8, 2018

marcaurele Aug 8, 2018

greut Aug 8, 2018

marcaurele Aug 9, 2018

resmo commented Aug 9, 2018

marcaurele commented Aug 10, 2018

resmo Aug 18, 2018 •

edited

greut Aug 28, 2018

marcaurele Aug 28, 2018

resmo Aug 28, 2018

marcaurele Aug 28, 2018

resmo Aug 28, 2018

resmo left a comment

resmo commented Aug 28, 2018

resmo commented Aug 28, 2018

ansibot commented Aug 28, 2018

resmo commented Aug 28, 2018

cs instance root_disk size update resizes the root volume #43817

cs instance root_disk size update resizes the root volume #43817

Conversation

greut commented Aug 8, 2018

SUMMARY

ISSUE TYPE

COMPONENT NAME

ANSIBLE VERSION

ADDITIONAL INFORMATION

ansibot commented Aug 8, 2018

ansibot commented Aug 8, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

resmo commented Aug 9, 2018

marcaurele commented Aug 10, 2018

resmo Aug 18, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

resmo left a comment

Choose a reason for hiding this comment

resmo commented Aug 28, 2018

resmo commented Aug 28, 2018

ansibot commented Aug 28, 2018

Components

Metadata

resmo commented Aug 28, 2018

resmo Aug 18, 2018 •

edited