Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware: New module : vmware_host_ssl_facts #43871

Merged
merged 1 commit into from
Aug 17, 2018
Merged

VMware: New module : vmware_host_ssl_facts #43871

merged 1 commit into from
Aug 17, 2018

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented Aug 9, 2018

SUMMARY

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/vmware/vmware_host_ssl_facts.py
test/integration/targets/vmware_host_ssl_facts/aliases
test/integration/targets/vmware_host_ssl_facts/tasks/main.yml

ANSIBLE VERSION
2.7-devel

@Akasurde
VMware: New module : vmware_host_ssl_facts
9fefe62 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot
Copy link
Contributor

ansibot commented Aug 9, 2018

cc @dav1x @warthog9
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. vmware VMware community labels Aug 9, 2018
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Aug 9, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 9, 2018

@bedecarroll @chrrrles @dav1x @garbled1 @imjoseangel @jjahns @kamsz @lrivallain @nafpliot-ibm @nerzhul @oboukili @pdellaert @rhoop @ritzk @stravassac @tchernomax @warthog9 @woshihaoren

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@Akasurde
Copy link
Member Author

@dericcrago @pdellaert Could you please review this ? Thanks.

pdellaert
pdellaert approved these changes Aug 17, 2018
View reviewed changes
Copy link
Contributor

@pdellaert pdellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) 👍

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 17, 2018
@Akasurde Akasurde merged commit 6caf0e8 into ansible:devel Aug 17, 2018
@Akasurde Akasurde deleted the vmware_host_ssl branch August 17, 2018 04:55
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pdellaert pdellaert pdellaert approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 cloud module This issue/PR relates to a module. new_module This PR includes a new module. new_plugin This PR includes a new plugin. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Akasurde @ansibot @pdellaert