Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ONTAP information gathering module #43888

Merged
merged 5 commits into from
Aug 28, 2018
Merged

ONTAP information gathering module #43888

merged 5 commits into from
Aug 28, 2018

Conversation

dprts
Copy link
Contributor

@dprts dprts commented Aug 9, 2018

SUMMARY

This module allows you to gather various information about ONTAP configuration

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

na_ontap_gather_facts

ANSIBLE VERSION

2.7

@ansibot
Copy link
Contributor

ansibot commented Aug 9, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/na_ontap_gather_facts.py:120:4: dangerous-default-value Dangerous default value {} as argument

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/na_ontap_gather_facts.py:69:0: ImportError: No module named xmltodict

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/na_ontap_gather_facts.py:69:0: ImportError: No module named xmltodict

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/na_ontap_gather_facts.py:69:0: ImportError: No module named 'xmltodict'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/na_ontap_gather_facts.py:69:0: ModuleNotFoundError: No module named 'xmltodict'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/na_ontap_gather_facts.py:69:0: ModuleNotFoundError: No module named 'xmltodict'

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/na_ontap_gather_facts.py:30:26: W291 trailing whitespace

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 9, 2018

cc @amit0701 @carchi8py @hulquest @lmprice @ndswartz @schmots1
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 ci_verified Changes made in this PR are causing tests to fail. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. netapp new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. storage support:community This issue/PR relates to code supported by the Ansible community. labels Aug 9, 2018
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Aug 10, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 10, 2018

The test ansible-test sanity --test no-underscore-variable [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/na_ontap_gather_facts.py:242:9: use `dummy` instead of `_` for a variable name

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Aug 10, 2018
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Aug 10, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 10, 2018

@amit0701 @carchi8py @hulquest @lmprice @ndswartz @schmots1

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 10, 2018
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Aug 13, 2018
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Aug 14, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 22, 2018
carchi8py
carchi8py approved these changes Aug 23, 2018
View reviewed changes
Copy link
Contributor

@carchi8py carchi8py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shipit

lonico
lonico approved these changes Aug 23, 2018
View reviewed changes
lib/ansible/modules/storage/netapp/na_ontap_gather_facts.py
- Returns "info"
default: "info"
required: false
choices: ['info']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we would have liked to only use present and absent for state.

But since it's optional, no big deal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll keep it like this.

lib/ansible/modules/storage/netapp/na_ontap_gather_facts.py

if query:
for k, v in query.items():
# Can v be nested?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alas, yes.

@Matthias-Beck
Added vserver_info
9f00fde 
Get vserver information
@ansibot
Copy link
Contributor

ansibot commented Aug 28, 2018

@dprts this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Aug 28, 2018
@dprts dprts changed the title ONTAP information gathering module [WIP] ONTAP information gathering module Aug 28, 2018
@ansibot ansibot added the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Aug 28, 2018
@ansibot ansibot removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Aug 28, 2018
@dprts dprts changed the title [WIP] ONTAP information gathering module ONTAP information gathering module Aug 28, 2018
@dprts
Copy link
Contributor Author

dprts commented Aug 28, 2018

ready_for_review

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. labels Aug 28, 2018
schmots1
schmots1 approved these changes Aug 28, 2018
View reviewed changes
Copy link
Contributor

@schmots1 schmots1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@gundalow
Copy link
Contributor

@lonico just checking, are you happy for this to be merged?

@ansibot ansibot removed the new_contributor This PR is the first contribution by a new community member. label Aug 28, 2018
@carchi8py
Copy link
Contributor

@gundalow Laurent @lonico is currently out right now, but we are good with this change being merged in.

@gundalow gundalow merged commit 966c87e into ansible:devel Aug 28, 2018
@dprts dprts deleted the na_ontap_gather_facts branch August 29, 2018 08:46
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carchi8py carchi8py carchi8py approved these changes

@lonico lonico lonico approved these changes

@schmots1 schmots1 schmots1 approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. netapp new_module This PR includes a new module. new_plugin This PR includes a new plugin. storage support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@dprts @ansibot @gundalow @carchi8py @lonico @schmots1 @bcoca @Matthias-Beck