Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openvswitch_db : Handle column value conversion and idempotency in no_key case #43914

Merged
merged 2 commits into from
Aug 11, 2018
Merged

openvswitch_db : Handle column value conversion and idempotency in no_key case #43914

merged 2 commits into from
Aug 11, 2018

Conversation

gdpak
Copy link
Contributor

@gdpak gdpak commented Aug 10, 2018

SUMMARY

Cherry-pick #43869

  • 'value' argument if passed as boolean in playbook gets converted to standard template boolean string(True/False). Convert it to string to keep the user supplied value in playbook.
  • Idempotency was not handled in no_key case and even it was buggy in explicit 'key' case where it will not program the DB entry if column name is different but values are same. Fixed it by direct dict comparison of existing and wanted configurations.
  • Set become to True at task level so that test passes even if it not set in host vars.
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

openvswitch_db

ANSIBLE VERSION
2.6

@gdpak
openvswitch_db : Handle column value conversion and idempotency in no…
5563000 
…_key case (ansible#43869)

* change column value to string. handle idempotency in no key case

* fix unit test failures in baseline

(cherry picked from commit 8eaebf8)
@gdpak
change column value to string. handle idempotency in no key case
5676bd7
@ansibot
Copy link
Contributor

ansibot commented Aug 10, 2018

cc @Qalthos @ganeshrn @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.6 This issue/PR affects Ansible v2.6 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Aug 10, 2018
@gundalow gundalow removed the needs_triage Needs a first human triage before being processed. label Aug 10, 2018
@mattclay mattclay merged commit 9794e5b into ansible:stable-2.6 Aug 11, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.6 This issue/PR affects Ansible v2.6 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gdpak @ansibot @mattclay @gundalow