Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware: Concept documentation #43927

Merged
merged 2 commits into from
Aug 30, 2018
Merged

VMware: Concept documentation #43927

merged 2 commits into from
Aug 30, 2018

Conversation

Akasurde
Copy link
Member

SUMMARY

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docs/docsite/rst/vmware/vmware_concepts.rst

ANSIBLE VERSION
2.7-devel

@Akasurde
VMware: Concept documentation
f514afc 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot
Copy link
Contributor

ansibot commented Aug 10, 2018

The test ansible-test sanity --test no-smart-quotes [explain] failed with 1 error:

docs/docsite/rst/vmware/vmware_concepts.rst:19:116: use ASCII quotes `'` and `"` instead of Unicode quotes

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 10, 2018

cc @acozine
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 ci_verified Changes made in this PR are causing tests to fail. docs This issue/PR relates to or includes documentation. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 10, 2018
@Akasurde
update docs
6b4bab0 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 10, 2018
gundalow
gundalow approved these changes Aug 10, 2018
View reviewed changes
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a technical point of view

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Aug 10, 2018
@Akasurde Akasurde mentioned this pull request Aug 11, 2018
Closed
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 18, 2018
@acozine
Copy link
Contributor

acozine commented Aug 30, 2018

rebuild_merge

acozine
acozine approved these changes Aug 30, 2018
View reviewed changes
Copy link
Contributor

@acozine acozine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Akasurde, looks good.

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 30, 2018
@ansibot ansibot merged commit 6059da2 into ansible:devel Aug 30, 2018
@Akasurde Akasurde deleted the vmware_basic_concept branch September 2, 2018 04:42
@dagwieers dagwieers added the vmware VMware community label Feb 10, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@acozine acozine acozine approved these changes

@gundalow gundalow gundalow approved these changes

@dagwieers dagwieers Awaiting requested review from dagwieers

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 cloud docs This issue/PR relates to or includes documentation. support:core This issue/PR relates to code supported by the Ansible Engineering Team. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Akasurde @ansibot @acozine @gundalow @dagwieers