Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sl_vm.py #43966

Merged
merged 3 commits into from Sep 25, 2018
Merged

Update sl_vm.py #43966

merged 3 commits into from Sep 25, 2018

Conversation

bankabanka
Copy link
Contributor

@bankabanka bankabanka commented Aug 10, 2018 •
edited by samdoran

Updated the list of datacenters to include new datacenters.

+label: docsite_pr

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/softlayer/sl_vm.py

ANSIBLE VERSION
2.7

@bankabanka
Update sl_vm.py
b30430b 
Updated the list of datacenters to include new datacenters.

+label: docsite_pr
@ansibot
Copy link
Contributor

ansibot commented Aug 10, 2018

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/cloud/softlayer/sl_vm.py:225:161: E501 line too long (212 > 160 characters)
lib/ansible/modules/cloud/softlayer/sl_vm.py:226:161: E501 line too long (167 > 160 characters)

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 10, 2018

cc @mcltn
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 ci_verified Changes made in this PR are causing tests to fail. cloud feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Aug 10, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 10, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/softlayer/sl_vm.py:225:0: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/softlayer/sl_vm.py:225:114: W291 trailing whitespace

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. small_patch labels Aug 10, 2018
@bankabanka
Copy link
Contributor Author

@mcltn what would be the timeframe to get this merged?

@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Aug 16, 2018
@ansibot ansibot added the bug This issue/PR relates to a bug. label Aug 16, 2018
@dagwieers dagwieers added the docsite_pr This PR is created from documentation using the "Edit on GitHub" link. label Aug 21, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 21, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 6, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed community_review In order to be merged, this PR must follow the community review workflow. support:community This issue/PR relates to code supported by the Ansible community. labels Sep 14, 2018
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 14, 2018
@gundalow
Copy link
Contributor

@mcltn Hi, could you please review this. Thanks in advance

mcltn
mcltn approved these changes Sep 18, 2018
View reviewed changes
Copy link
Contributor

@mcltn mcltn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these. We should look into getting this list form the API as well for future datacenters.

@camporter camporter mentioned this pull request Sep 19, 2018
Closed
@gundalow gundalow merged commit d1688ad into ansible:devel Sep 25, 2018
gundalow pushed a commit to gundalow/ansible that referenced this pull request Sep 25, 2018
@bankabanka @gundalow
Update sl_vm.py (ansible#43966)
a1b0510 
* Update sl_vm.py

Updated the list of datacenters to include new datacenters.
(cherry picked from commit d1688ad)
@gundalow
Copy link
Contributor

@bankabanka Thank you for this PR, your first I believe.

It does take us a while to get these review and merged, though that's now been done, thanks to @mcltn

Backport so we updates the docs in 2.7 will be done via #46109

Thanks again!

acozine pushed a commit that referenced this pull request Sep 25, 2018
@gundalow @acozine
Update sl_vm.py (#43966) (#46109)
8712f0f 
* Update sl_vm.py
Updated the list of softlayer datacenters
(cherry picked from commit d1688ad)
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcltn mcltn mcltn approved these changes

@achinthagunasekara achinthagunasekara achinthagunasekara approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. docsite_pr This PR is created from documentation using the "Edit on GitHub" link. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bankabanka @ansibot @gundalow @mcltn @achinthagunasekara @dagwieers @samdoran