Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add no-change handlers and fix utf8 #44020

Merged
merged 1 commit into from
Aug 13, 2018
Merged

Add no-change handlers and fix utf8 #44020

merged 1 commit into from
Aug 13, 2018

Conversation

caphrim007
Copy link
Contributor

SUMMARY

the bigip_command module was not handling utf-8 appropriately. Also,
this patch includes some enhancements for no-change detection

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

bigip_command

ANSIBLE VERSION
ansible 2.7.0.dev0
  config file = None
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python2.7/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.15 (default, Jul 25 2018, 18:19:34) [GCC 6.3.0 20170516]
ADDITIONAL INFORMATION

@caphrim007
Add no-change handlers and fix utf8
0597d25 
the bigip_command module was not handling utf-8 appropriately. Also,
this patch includes some enhancements for no-change detection
@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. f5 module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Aug 13, 2018
@caphrim007 caphrim007 removed the needs_triage Needs a first human triage before being processed. label Aug 13, 2018
@caphrim007 caphrim007 merged commit 0beae82 into ansible:devel Aug 13, 2018
@caphrim007 caphrim007 mentioned this pull request Aug 13, 2018
Closed
@caphrim007 caphrim007 deleted the bugfix.add-no-change-handlers-and-fix-utf8 branch August 28, 2018 17:10
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. f5 module This issue/PR relates to a module. networking Network category owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@caphrim007 @ansibot