Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New GCP Module: gcp_compute_target_vpn_gateway_facts #44049

Merged
merged 1 commit into from
Aug 17, 2018
Merged

New GCP Module: gcp_compute_target_vpn_gateway_facts #44049

merged 1 commit into from
Aug 17, 2018

Conversation

rambleraptor
Copy link
Contributor

@rambleraptor rambleraptor commented Aug 13, 2018 •
edited

SUMMARY

New GCP Module: gcp_compute_target_vpn_gateway_facts

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

gcp_compute_target_vpn_gateway_facts

ANSIBLE VERSION
2.7
ADDITIONAL INFORMATION
This was generated by [Magic Modules](https://github.com/googlecloudplatform/magic-modules)

@ansibot
Copy link
Contributor

ansibot commented Aug 13, 2018

@rambleraptor Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 13, 2018

cc @erjohnso
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 cloud gce module This issue/PR relates to a module. needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. core_review In order to be merged, this PR must follow the core review workflow. labels Aug 13, 2018
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Aug 13, 2018
@ryansb
Copy link
Contributor

ryansb commented Aug 14, 2018

bot_status

@ansibot
Copy link
Contributor

ansibot commented Aug 14, 2018

Components

lib/ansible/module_utils/gcp_utils.py
support: core
maintainers:

lib/ansible/modules/cloud/google/gcp_compute_target_vpn_gateway_facts.py
support: community
maintainers: erjohnso rambleraptor

lib/ansible/utils/module_docs_fragments/gcp.py
support: core
maintainers:

Metadata

waiting_on: ansible
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 1
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): rambleraptor
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 14, 2018
@rambleraptor rambleraptor force-pushed the gcp_compute_target_vpn_gateway_facts branch from 5f7ad79 to fc6d27d Compare August 17, 2018 05:15
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 17, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 17, 2018

@GwenaelPellenArkeup @bennojoy @dohoangkhiem @erjohnso @GoogleCloudPlatform @nitaco @robwagner33 @walbert947

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ryansb ryansb merged commit 9abe668 into ansible:devel Aug 17, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryansb ryansb ryansb approved these changes

Assignees

@ryansb ryansb

Labels
affects_2.7 This issue/PR affects Ansible v2.7 cloud community_review In order to be merged, this PR must follow the community review workflow. gce module This issue/PR relates to a module. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rambleraptor @ansibot @ryansb @samdoran