Locate prtdiag even when absent from /usr/bin #44113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Solaris 8 hosts, this prevents fact collection from aborting with:
Argument 'args' to run_command must be list or string
ansibot
added
affects_2.7
|
The test |
ansibot
added
the
needs_revision
webknjaz
removed
the
needs_triage
ansibot
removed
the
needs_revision
ansibot
added
the
stale_ci
ansibot
added
the
support:community
ansibot
removed
the
support:core
bcoca
requested changes
Oct 11, 2018
| # but that's okay, because we know where to find the real thing: | ||
| if not prtdiag_path: | ||
| rc, platform, err = self.module.run_command('/usr/bin/uname -i') | ||
| prtdiag_path = '/usr/platform/' + platform.rstrip() + '/sbin/prtdiag' |
There was a problem hiding this comment.
instead of assuming that if not found this path does exist, just pass the search pat as an option to get_bin_path and it will error out if even this fallback is not present
There was a problem hiding this comment.
Will do. Fact gathering is already slow, so I was reluctant to add an additional fork and exec of uname unless it was required.
There was a problem hiding this comment.
you could still make it conditional, just call get_bin_path again instead of assuming that the binary exists
ansibot
added
the
needs_revision
bcoca
approved these changes
Oct 11, 2018
mavit
added a commit
to mavit/ansible
that referenced
this pull request
Oct 12, 2018
* Locate prtdiag even when absent from /usr/bin
On Solaris 8 hosts, this prevents fact collection from aborting with:
Argument 'args' to run_command must be list or string
* Lint fix.
* Style: pass /usr/platform/.../sbin as optional path to get_bin_path().
(cherry picked from commit 40fb992)
abadger
pushed a commit
that referenced
this pull request
Oct 12, 2018
* Locate prtdiag even when absent from /usr/bin
On Solaris 8 hosts, this prevents fact collection from aborting with:
Argument 'args' to run_command must be list or string
* Lint fix.
* Style: pass /usr/platform/.../sbin as optional path to get_bin_path().
(cherry picked from commit 40fb992)
Tomorrow9
pushed a commit
to Tomorrow9/ansible
that referenced
this pull request
Dec 4, 2018
* Locate prtdiag even when absent from /usr/bin
On Solaris 8 hosts, this prevents fact collection from aborting with:
Argument 'args' to run_command must be list or string
* Lint fix.
* Style: pass /usr/platform/.../sbin as optional path to get_bin_path().
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
On Solaris 8, the
prtdiagwrapper is absent from/usr/sbin, so we must find the real thing ourselves. This prevents fact collection from aborting.ISSUE TYPE
COMPONENT NAME
Hardware facts.
ANSIBLE VERSION
ADDITIONAL INFORMATION
Before:
After: