Populate product_name and system_vendor facts on Solaris

[mavit]

SUMMARY

The first line of prtdiag on Solaris mentions the manufacturer and model name of the hardware. Unfortunately, these two fields are not reliably delineated, so some guesswork is required.

The existing code assumes that the model name consists of three words, with the middle word being "Enterprise". Whilst this is often true for recent Oracle hardware, it isn't true for a lot of other equipment that's still out there. By using a hard-coded list of known manufacturers, we can make a better attempt at separating the two parts.

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

Hardware facts.

ANSIBLE VERSION

ansible 2.7.0.dev0 (solaris-system-vendor 12a36255d7) last updated 2018/08/14 10:03:25 (GMT +100)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/username/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/username/src/ansible/lib/ansible
  executable location = /home/username/src/ansible/bin/ansible
  python version = 2.7.5 (default, Jul 13 2018, 13:06:57) [GCC 4.8.5 20150623 (Red Hat 4.8.5-28)]

ADDITIONAL INFORMATION

Before:

$ ansible -m setup sparc-server | egrep 'system_vendor|product_name'
<no output>

After:

$ ansible -m setup sparc-server | egrep 'system_vendor|product_name'
        "ansible_product_name": "Sun Fire V120 (UltraSPARC-IIe 648MHz)", 
        "ansible_system_vendor": "Sun Microsystems", 

[mator]

Tested with solaris 10 and solaris 11 under vmware.
Before changes

$ ansible solaris11 -m setup | egrep 'system_vendor|product_name'
<no output>
$ ansible -o solaris11 -m setup -a filter='ansible_system_vendor'
solaris11 | SUCCESS => {"ansible_facts": {}, "changed": false}

after patch(es) applied:

$ ansible solaris11 -m setup | egrep 'system_vendor|product_name' 
        "ansible_product_name": "VMware Virtual Platform", 
        "ansible_system_vendor": "VMware, Inc.", 

[mator]

@mavit can you rebase to latest ansible git version - https://docs.ansible.com/ansible/latest/dev_guide/developing_rebasing.html

@alikins can you please apply this pull request?! Thanks!

[dagwieers]

LGTM, may need to be backported to v2.7 too.

[ansibot]

cc @L2G @bcoca @brontitall @dagwieers @dermute @jasperla @jpdasma @scathatheworm @szinck @troy2914 @xen0l
click here for bot help

[dagwieers]

@mavit Can you backport this to stable-2.7 ? https://docs.ansible.com/ansible/devel/community/development_process.html#backporting-merged-prs