Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added private_ipv4 to the hostvars in Scaleway dynamic inventory #44122

Merged
merged 1 commit into from
Aug 28, 2018
Merged

Added private_ipv4 to the hostvars in Scaleway dynamic inventory #44122

merged 1 commit into from
Aug 28, 2018

Conversation

remyleone
Copy link
Contributor

SUMMARY

This PR adds private_ipv4 to the ansible hostvars of each hosts

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • scaleway_dynamic_inventory
ANSIBLE VERSION
ansible 2.7.0.dev0 (private_ipv4_hostvars 7ae34d5da1) last updated 2018/08/14 16:51:17 (GMT +200)
  config file = None
  configured module search path = [u'/Users/sieben/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/sieben/workspace/ansible/lib/ansible
  executable location = /Users/sieben/workspace/ansible/bin/ansible
  python version = 2.7.15 (default, Jun 17 2018, 12:46:58) [GCC 4.2.1 Compatible Apple LLVM 9.1.0 (clang-902.0.39.2)]

@g1franc
Copy link

g1franc commented Aug 14, 2018

Thanks for the update

@remyleone
Copy link
Contributor Author

@pilou- This is tested by @g1franc and reported to work. If everything is alright on your side, could you merge it?

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 14, 2018
@webknjaz webknjaz requested a review from bcoca August 14, 2018 16:15
@webknjaz webknjaz removed the needs_triage Needs a first human triage before being processed. label Aug 14, 2018
@pilou-
Copy link
Contributor

pilou- commented Aug 14, 2018

LGTM

@ansibot
Copy link
Contributor

ansibot commented Aug 14, 2018

cc @hekonsek
click here for bot help

@ansibot ansibot added cloud inventory Inventory category labels Aug 14, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 23, 2018
@remyleone remyleone mentioned this pull request Aug 23, 2018
Closed
@remyleone
Copy link
Contributor Author

Could this be merged?

@Spredzy
Copy link
Contributor

Spredzy commented Aug 28, 2018

shipit

@ansibot ansibot added scaleway shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 28, 2018
@maxamillion
Copy link
Contributor

rebuild_merge

@ansibot ansibot merged commit 70adbb8 into ansible:devel Aug 28, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pilou- pilou- pilou- approved these changes

@achinthagunasekara achinthagunasekara achinthagunasekara approved these changes

@bcoca bcoca Awaiting requested review from bcoca

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 cloud feature This issue/PR relates to a feature request. inventory Inventory category scaleway shipit This PR is ready to be merged by Core small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@remyleone @g1franc @pilou- @ansibot @Spredzy @maxamillion @achinthagunasekara @webknjaz