Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap default for INVALID_TASK_ATTRIBUTE_FAILED to True #44138

Merged
merged 1 commit into from
Aug 16, 2018

Conversation

sivel
Copy link
Member

@sivel sivel commented Aug 14, 2018

SUMMARY

Swap default for INVALID_TASK_ATTRIBUTE_FAILED to True, add additional info to exception

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lib/ansible/config/base.yml
lib/ansible/playbook/task.py

ANSIBLE VERSION
2.7
ADDITIONAL INFORMATION

@sivel sivel requested a review from bcoca August 14, 2018 19:21
@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 14, 2018
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Aug 15, 2018
@sivel sivel merged commit 509e92e into ansible:devel Aug 16, 2018
@mattclay
Copy link
Member

@sivel This change is breaking the aws_elasticbeanstalk_app integration test:

2018-08-17 04:25:27 ERROR! 'ignore_error' is not a valid attribute for a Task
2018-08-17 04:25:27 
2018-08-17 04:25:27 The error appears to have been in '/root/ansible/test/integration/targets/aws_elasticbeanstalk_app/tasks/main.yml': line 121, column 5, but may
2018-08-17 04:25:27 be elsewhere in the file depending on the exact syntax problem.
2018-08-17 04:25:27 
2018-08-17 04:25:27 The offending line appears to be:
2018-08-17 04:25:27 
2018-08-17 04:25:27   # ============================================================
2018-08-17 04:25:27   - name: delete non existent app
2018-08-17 04:25:27     ^ here
2018-08-17 04:25:27 
2018-08-17 04:25:27 This error can be suppressed as a warning using the "invalid_task_attribute_failed" configuration

Other tests that are excluded from smoke tests may also be impacted.

@bcoca
Copy link
Member

bcoca commented Aug 17, 2018

@mattclay actually 'working as intended', the test is incorrect, it should be plural ignore_errors

@mattclay
Copy link
Member

@bcoca Yes, @sivel fixed this in #44317

@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.7 This issue/PR affects Ansible v2.7 feature This issue/PR relates to a feature request. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants