Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mandatory filter error message more verbose #44139

Merged
merged 1 commit into from
Aug 17, 2018
Merged

Make mandatory filter error message more verbose #44139

merged 1 commit into from
Aug 17, 2018

Conversation

stoned
Copy link
Contributor

@stoned stoned commented Aug 14, 2018 •
edited by samdoran

SUMMARY

...by adding the undefined variable/attribute name, if available.

Provide more information when the mandatory filter fails by giving the name of the undefined variable or attribute.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lib/ansible/plugins/filter/core.py

ANSIBLE VERSION
ansible 2.7.0.dev0 (mandatory-with-name f14f45cf0b) last updated 2018/08/14 20:59:04 (GMT +200)
  config file = /home/seb/.ansible.cfg
  configured module search path = [u'/home/seb/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /u/seb/ghq/github.com/stoned/ansible/lib/ansible
  executable location = /u/seb/ghq/github.com/stoned/ansible/bin/ansible
  python version = 2.7.15 (default, May 16 2018, 17:50:09) [GCC 8.1.1 20180502 (Red Hat 8.1.1-1)]
ADDITIONAL INFORMATION

@stoned
Make mandatory filter error message more verbose
f14f45c 
...by adding the undefined variable/attribute name, if available.
@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 14, 2018
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Aug 16, 2018
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Aug 16, 2018
@samdoran samdoran merged commit e5f4987 into ansible:devel Aug 17, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 feature This issue/PR relates to a feature request. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stoned @samdoran @ansibot