Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ontap_command.py Module #44190

Merged
merged 3 commits into from
Aug 28, 2018
Merged

Add ontap_command.py Module #44190

merged 3 commits into from
Aug 28, 2018

Conversation

carchi8py
Copy link
Contributor

SUMMARY

add na_ontap_command.py

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
  • na_ontap_command.py
ANSIBLE VERSION
bash-3.2# ansible --version
ansible 2.7.0.dev0 (sf_commonfiles caf71e24dd) last updated 2018/08/06 10:46:57 (GMT -700)
  config file = None
  configured module search path = [u'/Users/chrisarchibald/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /private/tmp/ansible/lib/ansible
  executable location = /private/tmp/ansible/bin/ansible
  python version = 2.7.12 (default, Oct 11 2016, 05:20:59) [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.38)]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Aug 15, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/na_ontap_command.py:103:1: E305 expected 2 blank lines after class or function definition, found 1

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 15, 2018

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 ci_verified Changes made in this PR are causing tests to fail. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. netapp new_module This PR includes a new module. new_plugin This PR includes a new plugin. storage support:community This issue/PR relates to code supported by the Ansible community. labels Aug 15, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 15, 2018

@amit0701 @hulquest @lmprice @ndswartz @schmots1

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 15, 2018
Copy link
Contributor

@schmots1 schmots1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Aug 16, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed shipit This PR is ready to be merged by Core labels Aug 23, 2018
Copy link
Contributor

@schmots1 schmots1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 24, 2018
@gundalow gundalow merged commit fe14781 into ansible:devel Aug 28, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.7 This issue/PR affects Ansible v2.7 module This issue/PR relates to a module. netapp new_module This PR includes a new module. new_plugin This PR includes a new plugin. shipit This PR is ready to be merged by Core storage support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants