Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes for ontap_export_policy.py #44194

Merged
merged 2 commits into from
Aug 16, 2018
Merged

Bug fixes for ontap_export_policy.py #44194

merged 2 commits into from
Aug 16, 2018

Conversation

carchi8py
Copy link
Contributor

SUMMARY

Bug fixes for ontap_export_policy.py

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • na_ontap_export_policy.py
ANSIBLE VERSION
bash-3.2# ansible --version
ansible 2.7.0.dev0 (sf_commonfiles caf71e24dd) last updated 2018/08/06 10:46:57 (GMT -700)
  config file = None
  configured module search path = [u'/Users/chrisarchibald/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /private/tmp/ansible/lib/ansible
  executable location = /private/tmp/ansible/bin/ansible
  python version = 2.7.12 (default, Oct 11 2016, 05:20:59) [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.38)]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Aug 15, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/na_ontap_export_policy.py:0:0: E309 version_added for new option (from_name) should be 2.7. Currently 0.0

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 15, 2018

cc @amit0701 @hulquest @lmprice @ndswartz @schmots1
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. ci_verified Changes made in this PR are causing tests to fail. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. netapp owner_pr This PR is made by the module's maintainer. storage support:community This issue/PR relates to code supported by the Ansible community. labels Aug 15, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 15, 2018
schmots1
schmots1 approved these changes Aug 16, 2018
View reviewed changes
Copy link
Contributor

@schmots1 schmots1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Aug 16, 2018
@ansibot ansibot merged commit b835659 into ansible:devel Aug 16, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmots1 schmots1 schmots1 approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. module This issue/PR relates to a module. netapp owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core storage support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carchi8py @ansibot @schmots1