Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fixes for ontap_net_vlan.py #44209

Merged
merged 2 commits into from
Aug 22, 2018
Merged

Bug Fixes for ontap_net_vlan.py #44209

merged 2 commits into from
Aug 22, 2018

Conversation

carchi8py
Copy link
Contributor

SUMMARY

Bug Fixes for ontap_net_vlan.py

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • na_ontap_net_vlan.py
ANSIBLE VERSION
bash-3.2# ansible --version
ansible 2.7.0.dev0 (sf_commonfiles caf71e24dd) last updated 2018/08/06 10:46:57 (GMT -700)
  config file = None
  configured module search path = [u'/Users/chrisarchibald/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /private/tmp/ansible/lib/ansible
  executable location = /private/tmp/ansible/bin/ansible
  python version = 2.7.12 (default, Oct 11 2016, 05:20:59) [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.38)]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Aug 15, 2018

cc @amit0701 @hulquest @lmprice @ndswartz @schmots1
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. netapp owner_pr This PR is made by the module's maintainer. storage support:community This issue/PR relates to code supported by the Ansible community. labels Aug 15, 2018
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Aug 16, 2018
gundalow
gundalow reviewed Aug 17, 2018
View reviewed changes
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes options from a module releases in 2.6, that may break your users

gundalow
gundalow requested changes Aug 17, 2018
View reviewed changes
lib/ansible/modules/storage/netapp/na_ontap_net_vlan.py
@@ -81,8 +75,6 @@ def __init__(self):
parent_interface=dict(required=True, type='str'),
vlanid=dict(required=True, type='str'),
node=dict(required=True, type='str'),
interface_name=dict(required=False, type='str'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interface_name has been removed which was in using in 2.6, though docs don't explain what you should use instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where should we document this?

ONTAP required interface name to be - anything else would result in an error. Since we are already getting these 2 part of we don't need to ask the user for the interface name to create the correct name.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the DOCUMENTION section, possibly under notes:

Also if users of this module in Ansible 2.6 will need to modify there playbooks to work with Ansible 2.7 is should also be documented in docs/docsite/rst/porting_guides/porting_guide_2.7.rst

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 17, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 21, 2018

cc @acozine
click here for bot help

@ansibot ansibot added docs This issue/PR relates to or includes documentation. support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed owner_pr This PR is made by the module's maintainer. labels Aug 21, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 22, 2018
@gundalow gundalow merged commit 66ae8ef into ansible:devel Aug 22, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. netapp storage support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@carchi8py @ansibot @gundalow @samdoran