Update cnos_backup.py #44246
Merged
Update cnos_backup.py #44246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.7
|
The test |
ansibot
added
ci_verified
Qalthos
reviewed
Aug 16, 2018
| description: | ||
| - This module allows you to work with switch configurations. It provides a | ||
| way to back up the running or startup configurations of a switch to a | ||
| remote server. This is achieved by periodically saving a copy of the | ||
| startup or running configuration of the network device to a remote server | ||
| using FTP, SFTP, TFTP, or SCP. The first step is to create a directory from | ||
| using FTP, SFTP, TFTP, or SCP. The first step is to create directory from |
There was a problem hiding this comment.
Did you mean to drop the word 'a' here?
There was a problem hiding this comment.
Will add the 'a' back
There was a problem hiding this comment.
Will also remove the unwanted code from cnos.py along with this PR
ansibot
removed
the
needs_triage
Qalthos
suggested changes
Aug 16, 2018
There was a problem hiding this comment.
Unused code in cnos.py will be removed later together with few more modules
I think I get why you are doing this, if you've been making edits to module_utils/cnos and it is hard to filter out what changes go for which module PR, but it makes this much harder to review and will make the later PR with many unrelated changes to the module_utils code much harder to review. I feel it should not be too onerous to ask you to keep related changes together.
ansibot
added
needs_revision
ansibot
added
needs_ci
ansibot
added
stale_ci
|
Done as per the review coments |
Qalthos
approved these changes
Aug 17, 2018
ansibot
added
core_review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In this PR I am moving the code which is in util file cnos.py to respective module code. There was a review comment is this regard that util file is of huge size. This is an effort to reduce the size.
ISSUE TYPE
COMPONENT NAME
lib\ansible\modules\network\cnos\cnos_backup.py
ANSIBLE VERSION
ansible 2.7.0.dev0 (devel f9cbdcd) last updated 2018/07/03 14:55:43 (GMT +550)
config file = /etc/ansible/ansible.cfg
configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
ansible python module location = /home/ansible/sheru/ansible/lib/ansible
executable location = /home/ansible/sheru/ansible/bin/ansible
python version = 2.7.6 (default, Nov 23 2017, 15:49:48) [GCC 4.8.4]
ADDITIONAL INFORMATION
Unused code in cnos.py will be removed later together with few more modules