-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new session parameter to win_psexec #44263
Merged
jborean93
merged 3 commits into
ansible:devel
from
Xyon:feature/win-psexec-session-selection
Aug 28, 2018
Merged
Add new session parameter to win_psexec #44263
jborean93
merged 3 commits into
ansible:devel
from
Xyon:feature/win-psexec-session-selection
Aug 28, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.7
This issue/PR affects Ansible v2.7
community_review
In order to be merged, this PR must follow the community review workflow.
feature
This issue/PR relates to a feature request.
module
This issue/PR relates to a module.
needs_triage
Needs a first human triage before being processed.
python3
support:community
This issue/PR relates to code supported by the Ansible community.
windows
Windows community
labels
Aug 16, 2018
This comment has been minimized.
This comment has been minimized.
ansibot
added
ci_verified
Changes made in this PR are causing tests to fail.
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
and removed
community_review
In order to be merged, this PR must follow the community review workflow.
labels
Aug 16, 2018
ansibot
added
community_review
In order to be merged, this PR must follow the community review workflow.
and removed
ci_verified
Changes made in this PR are causing tests to fail.
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
labels
Aug 16, 2018
samdoran
removed
the
needs_triage
Needs a first human triage before being processed.
label
Aug 16, 2018
dagwieers
approved these changes
Aug 16, 2018
dagwieers
previously requested changes
Aug 16, 2018
@@ -65,6 +65,11 @@ | |||
- Run the program so that it interacts with the desktop on the remote system. | |||
type: bool | |||
default: 'no' | |||
session: | |||
description: | |||
- In conjunction with interactive, specify a session for psexec to attach to. Has no effect if interactive is 'no'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We prefer if the first entry of the description is the summary of what the parameter is for.
Subsequent entries can clarify how it is used. So I would do:
session:
description:
- Specifies the session ID to use.
- This parameter works in conjunction with parameter C(interactive).
- It has no effect when C(interactive) is set to C(no).
type: int
version_added: '2.7'
ansibot
added
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
and removed
community_review
In order to be merged, this PR must follow the community review workflow.
labels
Aug 16, 2018
ansibot
added
the
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
label
Aug 24, 2018
jborean93
approved these changes
Aug 28, 2018
Have added the changelog fragment and edited the doc to match @dagwieers recommendations. Thanks @Xyon for the PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.7
This issue/PR affects Ansible v2.7
feature
This issue/PR relates to a feature request.
module
This issue/PR relates to a module.
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
python3
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
support:community
This issue/PR relates to code supported by the Ansible community.
windows
Windows community
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Allows users to specify the Windows session they would like psexec to interact with, per the documentation for psexec around the -i flag.
ISSUE TYPE
COMPONENT NAME
win_psexec
ANSIBLE VERSION
ADDITIONAL INFORMATION