Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware: minor fix for vmware_deploy_ovf #44299

Merged
merged 1 commit into from
Aug 20, 2018
Merged

VMware: minor fix for vmware_deploy_ovf #44299

merged 1 commit into from
Aug 20, 2018

Conversation

Akasurde
Copy link
Member

SUMMARY
  • Check value of ovf path
  • Assign variable before using

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/vmware/vmware_deploy_ovf.py

ANSIBLE VERSION
2.7-devel

@Akasurde
VMware: minor fix for vmware_deploy_ovf
c698b72 
* Check value of ovf path
* Assign variable before using

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot
Copy link
Contributor

ansibot commented Aug 17, 2018

cc @dav1x @sivel @warthog9
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Aug 17, 2018
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Aug 17, 2018
@Im0
Copy link
Contributor

Im0 commented Aug 18, 2018

LGTM

Tested on VMware vCenter 6.7.

@Akasurde Akasurde merged commit d06d1d4 into ansible:devel Aug 20, 2018
@Akasurde Akasurde deleted the deploy_ovf_fix branch August 20, 2018 04:09
@Akasurde
Copy link
Member Author

@Im0 @achinthagunasekara Thanks for the review.

@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@achinthagunasekara achinthagunasekara achinthagunasekara approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Akasurde @ansibot @Im0 @achinthagunasekara @mkrizek