-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix module name in error text at parse_xml filter #44313
Merged
ganeshrn
merged 2 commits into
ansible:devel
from
matshch:patch/fix-parse_xml-error-naming
Aug 20, 2018
Merged
Fix module name in error text at parse_xml filter #44313
ganeshrn
merged 2 commits into
ansible:devel
from
matshch:patch/fix-parse_xml-error-naming
Aug 20, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.7
This issue/PR affects Ansible v2.7
bug
This issue/PR relates to a bug.
needs_triage
Needs a first human triage before being processed.
networking
Network category
new_contributor
This PR is the first contribution by a new community member.
python3
small_patch
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
labels
Aug 17, 2018
ganeshrn
approved these changes
Aug 17, 2018
ganeshrn
removed
the
needs_triage
Needs a first human triage before being processed.
label
Aug 17, 2018
@matshch Needs updating unit tests |
ansibot
added
the
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
label
Aug 17, 2018
@ganeshrn looks like now tests passes |
Closing and re-opening for CI trigger. |
ansibot
removed
the
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
label
Aug 18, 2018
@matshch Thank you! |
Hi,
|
gundalow
added
the
contrib_follow_up
https://github.com/ansible/community/issues/353
label
Oct 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.7
This issue/PR affects Ansible v2.7
bug
This issue/PR relates to a bug.
contrib_follow_up
https://github.com/ansible/community/issues/353
networking
Network category
new_contributor
This PR is the first contribution by a new community member.
python3
small_patch
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
test
This PR relates to tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Looks like error text in parse_xml filter was not changed after copy-pasting parse_cli filter. This pull request fixes module name in error text.
ISSUE TYPE
COMPONENT NAME
parse_xml filter
ANSIBLE VERSION
ADDITIONAL INFORMATION
While doing task with parse_xml filter, before:
After: