Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module name in error text at parse_xml filter #44313

Merged
merged 2 commits into from
Aug 20, 2018
Merged

Fix module name in error text at parse_xml filter #44313

merged 2 commits into from
Aug 20, 2018

Conversation

matshch
Copy link
Contributor

@matshch matshch commented Aug 17, 2018

SUMMARY

Looks like error text in parse_xml filter was not changed after copy-pasting parse_cli filter. This pull request fixes module name in error text.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

parse_xml filter

ANSIBLE VERSION
ansible 2.6.2
  config file = None
  configured module search path = ['/home/al/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python3.5/dist-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 3.5.2 (default, Nov 23 2017, 16:37:01) [GCC 5.4.0 20160609]
ADDITIONAL INFORMATION

While doing task with parse_xml filter, before:

fatal: [host.name]: FAILED! => {"msg": "unable to locate parse_cli template: /path/to/non/existing/template.yml"}

After:

fatal: [host.name]: FAILED! => {"msg": "unable to locate parse_xml template: /path/to/non/existing/template.yml"}

@ansibot
Copy link
Contributor

ansibot commented Aug 17, 2018

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. networking Network category new_contributor This PR is the first contribution by a new community member. python3 small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 17, 2018
@ganeshrn ganeshrn removed the needs_triage Needs a first human triage before being processed. label Aug 17, 2018
@ganeshrn
Copy link
Member

@matshch Needs updating unit tests

@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Aug 17, 2018
@ansibot ansibot added the test This PR relates to tests. label Aug 17, 2018
@matshch
Copy link
Contributor Author

matshch commented Aug 17, 2018

@ganeshrn looks like now tests passes

@Akasurde
Copy link
Member

Closing and re-opening for CI trigger.

@Akasurde Akasurde closed this Aug 18, 2018
@Akasurde Akasurde reopened this Aug 18, 2018
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Aug 18, 2018
@ganeshrn
Copy link
Member

@matshch Thank you!

@ganeshrn ganeshrn merged commit 8323f3e into ansible:devel Aug 20, 2018
@gundalow
Copy link
Contributor

Hi,
I'm randomly selecting some PRs to see how it was for you, with the aim of making it easier for future contributors. As a new contributor I'm particularly interested as you don't have any prior knowledge of the Ansible process.

  1. Generally speaking, how was the process for you?
  2. Did it make sense what to do to progress the PR?
  3. Did you read any of the developer (dev_guide) or contributor documentation?
  4. What in the documentation was useful or confusing, missing or could be improved
  5. Did you know you could run ansible-test locally?
  6. What areas would you be interested in contributing to?

ansible/community#353

@gundalow gundalow added the contrib_follow_up https://github.com/ansible/community/issues/353 label Oct 27, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. contrib_follow_up https://github.com/ansible/community/issues/353 networking Network category new_contributor This PR is the first contribution by a new community member. python3 small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants