Scaleway inventory: allows to connect via private IP #44342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansible_host was hardcoded and it was not possible to connect using
private addresses.
This allows to define multiple host variables, values are templates
which can use hosts details send by API. For example this config file
use private address and defines two variables:
plugin: scaleway
hostnames:
- hostname
variables:
ansible_host: private_ip
state: state
image: image.name
regions:
- ams1
inventory will looks like:
{
"_meta": {
"hostvars": {
"testhost": {
"ansible_host": "10.1.1.1",
"arch": "x86_64",
"commercial_type": "START1-M",
"hostname": "testhost",
"id": "af669464-0c74-4c89-8573-9fe763028448",
"image": "CentOS 7.4",
"organization": "2cc9a115-380d-4ac0-ba4b-8947eee71325",
"public_ipv4": "163.172.1.1",
"public_ipv6": "2001:bc8::1",
"state": "running",
"tags": [
"testtag"
]
}
}
},
[...]
}
ansibot
added
affects_2.7
|
LGTM |
ansibot
removed
the
needs_triage
achinthagunasekara
approved these changes
Aug 19, 2018
|
shipit |
|
bot_status |
Componentslib/ansible/plugins/inventory/scaleway.py Metadatawaiting_on: maintainer |
ansibot
added
scaleway
support:community
maxamillion
approved these changes
Aug 28, 2018
|
shipit |
1 similar comment
|
shipit |
|
rebuild_merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ansible_hostvalue was hardcoded with public IPv4 address.With this PR:
private IPv4 or public IPv6 can be used
by default
ansible_hostisn't defined (theninventory_hostnameis used, meaning value ofhostnamesparameter)other host variables can be defined, values of these variables are templates which can reference data send by Scaleway API:
inventory will look like:
{ "_meta": { "hostvars": { "testhost": { "ansible_host": "10.1.1.1", "arch": "x86_64", "commercial_type": "START1-M", "hostname": "testhost", "id": "af669464-0c74-4c89-8573-9fe763028448", "image": "CentOS 7.4", "organization": "2cc9a115-380d-4ac0-ba4b-8947eee71325", "public_ipv4": "163.172.1.1", "public_ipv6": "2001:bc8::1", "state": "running", "tags": [ "testtag" ] } } }, [...] }ISSUE TYPE
COMPONENT NAME
lib/ansible/plugins/inventory/scaleway.py
ANSIBLE VERSION