Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds bigip_firewall_policy module #44361

Merged
merged 1 commit into from
Aug 19, 2018
Merged

Adds bigip_firewall_policy module #44361

merged 1 commit into from
Aug 19, 2018

Conversation

caphrim007
Copy link
Contributor

SUMMARY

This module is used to manage firewall policy objects on a bigip.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

bigip_firewall_policy

ANSIBLE VERSION
ansible 2.7.0.dev0
  config file = /here/test/integration/ansible.cfg
  configured module search path = ['/here/library/modules']
  ansible python module location = /usr/local/lib/python3.6/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 3.6.6 (default, Jul 17 2018, 11:12:33) [GCC 6.3.0 20170516]
ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 core_review In order to be merged, this PR must follow the core review workflow. f5 module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. python3 support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Aug 19, 2018
@caphrim007 caphrim007 removed the needs_triage Needs a first human triage before being processed. label Aug 19, 2018
@caphrim007
Adds bigip_firewall_policy module
651d620 
This module is used to manage firewall policy objects on a bigip.
@caphrim007 caphrim007 force-pushed the feature.add-bigip-firewall-policy branch from c58afdf to 651d620 Compare August 19, 2018 06:09
@ansibot
Copy link
Contributor

ansibot commented Aug 19, 2018

The test ansible-test sanity --test pylint [explain] failed with 4 errors:

lib/ansible/modules/network/f5/bigip_firewall_policy.py:377:21: undefined-variable Undefined variable 'response'
lib/ansible/modules/network/f5/bigip_firewall_policy.py:377:34: undefined-variable Undefined variable 'response'
lib/ansible/modules/network/f5/bigip_firewall_policy.py:378:28: undefined-variable Undefined variable 'response'
lib/ansible/modules/network/f5/bigip_firewall_policy.py:379:36: undefined-variable Undefined variable 'response'

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 19, 2018
@caphrim007 caphrim007 merged commit 1148d57 into ansible:devel Aug 19, 2018
@caphrim007 caphrim007 deleted the feature.add-bigip-firewall-policy branch August 28, 2018 17:10
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 core_review In order to be merged, this PR must follow the core review workflow. f5 module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. python3 support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@caphrim007 @ansibot