Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix enable_snat parameter #44418

Merged
merged 1 commit into from
Aug 20, 2018
Merged

Fix enable_snat parameter #44418

merged 1 commit into from
Aug 20, 2018

Conversation

guilhermesteinmuller
Copy link
Contributor

SUMMARY

Fixes #44285

We don't need to set a default value to enable_snat parameter and it will only be enabled
when a user with the right policy set as True.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

os_router

ANSIBLE VERSION
ansible 2.6.2
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/dist-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.12 (default, Dec  4 2017, 14:50:18) [GCC 5.4.0 20160609]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Aug 20, 2018

cc @Shrews @dagnello @emonty @juliakreger @omgjlk @rcarrillocruz @Shrews @Thingee
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. openstack support:community This issue/PR relates to code supported by the Ansible community. labels Aug 20, 2018
@emonty
Copy link
Contributor

emonty commented Aug 20, 2018

shipit

@emonty emonty requested a review from Shrews August 20, 2018 20:53
@Shrews
Copy link
Contributor

Shrews commented Aug 20, 2018

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Aug 20, 2018
@ansibot ansibot merged commit b713978 into ansible:devel Aug 20, 2018
@guilhermesteinmuller guilhermesteinmuller mentioned this pull request Aug 21, 2018
Merged
guilhermesteinmuller added a commit to guilhermesteinmuller/ansible that referenced this pull request Aug 21, 2018
@guilhermesteinmuller
Add missing changelog for PR ansible#44418
1771dda 
The PR[1] was merged but we noticed that the
changelog file is missing.

[1] ansible#44418
guilhermesteinmuller added a commit to guilhermesteinmuller/ansible that referenced this pull request Aug 21, 2018
@guilhermesteinmuller
Fix enable_snat parameter (ansible#44418)
127dc81 
Fixes the issue ansible#44285
(cherry picked from commit b713978)
guilhermesteinmuller added a commit to guilhermesteinmuller/ansible that referenced this pull request Aug 21, 2018
@guilhermesteinmuller
Fix enable_snat parameter (ansible#44418)
7af79ba 
Fixes the issue ansible#44285
(cherry picked from commit b713978)
guilhermesteinmuller added a commit to guilhermesteinmuller/ansible that referenced this pull request Aug 21, 2018
@guilhermesteinmuller
Fix enable_snat parameter (ansible#44418)
61b3b88 
Fixes the issue ansible#44285
(cherry picked from commit b713978)
guilhermesteinmuller added a commit to guilhermesteinmuller/ansible that referenced this pull request Aug 21, 2018
@guilhermesteinmuller
Fix enable_snat parameter (ansible#44418)
2a24339 
Fixes the issue ansible#44285
(cherry picked from commit b713978)
guilhermesteinmuller added a commit to guilhermesteinmuller/ansible that referenced this pull request Aug 21, 2018
@guilhermesteinmuller
Fix enable_snat parameter (ansible#44418)
729233b 
Fixes the issue ansible#44285
(cherry picked from commit b713978)
guilhermesteinmuller added a commit to guilhermesteinmuller/ansible that referenced this pull request Aug 21, 2018
@guilhermesteinmuller
Fix enable_snat parameter (ansible#44418)
f45551a 
Fixes the issue ansible#44285
(cherry picked from commit b713978)
jborean93 pushed a commit that referenced this pull request Aug 23, 2018
@guilhermesteinmuller @jborean93
Add missing changelog for PR #44418 (#44478)
3db93e4 
The PR[1] was merged but we noticed that the
changelog file is missing.

[1] #44418
@jamescassell
Copy link
Contributor

Given that this is changing a default, should we warn users that the default changed? I've got a playbook that assumes the default is yes for this option.

mattclay pushed a commit that referenced this pull request Sep 4, 2018
@guilhermesteinmuller @mattclay
Fix enable_snat parameter (#44418) (#44448)
0db6467 
* Fix enable_snat parameter (#44418)

Fixes the issue #44285
(cherry picked from commit b713978)

* Fix enable_snat parameter (#44418)

Fixes the issue #44285
(cherry picked from commit b713978)

* Fix enable_snat parameter (#44418)

Fixes the issue #44285
(cherry picked from commit b713978)
nitzmahone pushed a commit that referenced this pull request Sep 5, 2018
@guilhermesteinmuller @nitzmahone
Fix enable_snat parameter (#44418) (#44451)
12d0684 
* Fix enable_snat parameter (#44418)

Fixes the issue #44285
(cherry picked from commit b713978)

* Fix enable_snat parameter (#44418)

Fixes the issue #44285
(cherry picked from commit b713978)

* Fix enable_snat parameter (#44418)

Fixes the issue #44285
(cherry picked from commit b713978)
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Shrews Shrews Awaiting requested review from Shrews

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. openstack shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

os_router always sets enable_snat to true
5 participants
@guilhermesteinmuller @ansibot @emonty @Shrews @jamescassell