Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation fix, decrypt is True by default #44435

Merged
merged 1 commit into from
Aug 21, 2018
Merged

Documentation fix, decrypt is True by default #44435

merged 1 commit into from
Aug 21, 2018

Conversation

HuffAndPuff
Copy link
Contributor

SUMMARY

The aws_ssm lookup actually decrypts values by default, contrary to the docs. This PR assumes that the code is correct and the docs are wrong which is of course a guess on my part. Perhaps it shouldn't decrypt by default?

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

aws_ssm lookup

ANSIBLE VERSION
ansible 2.6.1
  config file = /Users/joakim/ProReNata/Provision/ansible.cfg
  configured module search path = [u'/Users/joakim/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/joakim/Envs/provision/lib/python2.7/site-packages/ansible
  executable location = /Users/joakim/Envs/provision/bin/ansible
  python version = 2.7.10 (default, Oct  6 2017, 22:29:07) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.31)]
ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 21, 2018
@webknjaz webknjaz removed the needs_triage Needs a first human triage before being processed. label Aug 21, 2018
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Aug 21, 2018
@gundalow gundalow merged commit 88659dc into ansible:devel Aug 21, 2018
@gundalow
Copy link
Contributor

@HuffAndPuff Good spot, thank you for this fix. Your first PR to Ansible! 💯

gundalow pushed a commit to gundalow/ansible that referenced this pull request Aug 21, 2018
@HuffAndPuff @gundalow
Documentation fix, decrypt is True by default (ansible#44435)
b7b7e0e 
(cherry picked from commit 88659dc)
gundalow pushed a commit to gundalow/ansible that referenced this pull request Aug 21, 2018
@HuffAndPuff @gundalow
Documentation fix, decrypt is True by default (ansible#44435)
40e9590 
(cherry picked from commit 88659dc)
@acozine acozine mentioned this pull request Aug 24, 2018
Closed
acozine pushed a commit that referenced this pull request Aug 27, 2018
@gundalow
Documentation fix, decrypt is True by default (#44435) (#44472)
36fd4a2 
(cherry picked from commit 88659dc)
acozine pushed a commit that referenced this pull request Aug 27, 2018
@gundalow
Documentation fix, decrypt is True by default (#44435) (#44471)
81de1eb 
(cherry picked from commit 88659dc)
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@webknjaz webknjaz webknjaz approved these changes

@gundalow gundalow gundalow approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 docs This issue/PR relates to or includes documentation. new_contributor This PR is the first contribution by a new community member. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@HuffAndPuff @gundalow @webknjaz @ansibot