Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oVirt: Add depracation warning to all modules #44440

Merged
merged 1 commit into from
Aug 23, 2018
Merged

oVirt: Add depracation warning to all modules #44440

merged 1 commit into from
Aug 23, 2018

Conversation

machacekondra
Copy link
Contributor

SUMMARY

This PR renames modules from plural to singular and adds deprecation warning to all oVirt modules.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ovirt

ANSIBLE VERSION
2.5.3
ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. labels Aug 21, 2018
@machacekondra
Copy link
Contributor Author

@mwperina @ryansb @mkrizek

mwperina
mwperina approved these changes Aug 21, 2018
View reviewed changes
Copy link
Contributor

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ryansb
Copy link
Contributor

ryansb commented Aug 21, 2018

This has conflicts with devel that must be resolved with a rebase of your branch.

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Aug 21, 2018
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Aug 21, 2018
@machacekondra
Copy link
Contributor Author

Confictls resolved.

mwperina
mwperina approved these changes Aug 22, 2018
View reviewed changes
Copy link
Contributor

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Aug 23, 2018
@machacekondra
Copy link
Contributor Author

shipit

@ryansb ryansb merged commit 24c26ad into ansible:devel Aug 23, 2018
gerrit-ovirt-org pushed a commit to oVirt/ovirt-system-tests that referenced this pull request Aug 31, 2018
@machacekondra
ansible_suite: Fix ansible suite modules names
86a1d1e 
After this patch was merged:

 ansible/ansible#44440

We have to rename all modules from plural name to singular name.

Change-Id: I023e20eace62e58af057c545f99c38816e33fb9f
Signed-off-by: Ondra Machacek <omachace@redhat.com>
@dagwieers dagwieers added the virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) label Feb 8, 2019
@dagwieers dagwieers removed virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) labels Feb 21, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryansb ryansb ryansb approved these changes

@mwperina mwperina mwperina approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. ovirt oVirt and RHV community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@machacekondra @ryansb @mwperina @dagwieers @ansibot @jborean93