Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Use GitHub syntax highlighting styles #44449

Merged
merged 1 commit into from
Aug 23, 2018
Merged

docs: Use GitHub syntax highlighting styles #44449

merged 1 commit into from
Aug 23, 2018

Conversation

dagwieers
Copy link
Contributor

@dagwieers dagwieers commented Aug 21, 2018 •
edited

SUMMARY

This PR changes the CSS stylesheet so the documentation (and module)
examples look more like how they look on GitHub.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docs

ANSIBLE VERSION

v2.7

ADDITIONAL INFORMATION

(Screen shots taken here: https://docs.ansible.com/ansible/devel/modules/aci_rest_module.html)

Before:
screenshot from 2018-08-21 14-48-05

After:
screenshot from 2018-08-21 14-48-25

@dagwieers
docs: Use GitHub syntax highlighting styles
77e1171 
This PR changes the CSS stylesheet so the documentation (and module)
examples look more like how they look on GitHub.
@dagwieers dagwieers mentioned this pull request Aug 21, 2018
Merged
@dagwieers dagwieers added this to the 2.7.0 milestone Aug 21, 2018
@dagwieers dagwieers added this to To do in OLD Ansible Documentation via automation Aug 21, 2018
@dagwieers dagwieers requested a review from acozine August 21, 2018 12:53
@dagwieers dagwieers added the docs This issue/PR relates to or includes documentation. label Aug 21, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 21, 2018

cc @acozine
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 21, 2018
@dagwieers
Copy link
Contributor Author

dagwieers commented Aug 21, 2018 •
edited

Another example

(Screen shots taken here: https://docs.ansible.com/ansible/devel/modules/command_module.html)

Before:
screenshot from 2018-08-21 14-59-48

After:
screenshot from 2018-08-21 14-59-34

gundalow
gundalow approved these changes Aug 21, 2018
View reviewed changes
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs @acozine's approval though I like this, thanks!

@acozine acozine merged commit 47711d0 into ansible:devel Aug 23, 2018
@dagwieers
Copy link
Contributor Author

@gundalow @acozine It seems for docs.ansible.com we need to copy over the newer pygments.css file. I don't think this comes directly from the devel branch ? Not sure where the deployment scripts are for docs.ansible.com :-/

@gundalow
Copy link
Contributor

Fixing build: #44846

@dagwieers dagwieers added this to In progress in Contributor Experience via automation Sep 2, 2018
@dagwieers dagwieers moved this from In progress to Done in Contributor Experience Sep 2, 2018
@acozine acozine moved this from To do to Backport to 2.7 in OLD Ansible Documentation Sep 17, 2018
@acozine acozine moved this from Backport to 2.7 to Done in OLD Ansible Documentation Sep 20, 2018
@acozine acozine moved this from Done to Backport to 2.6 in OLD Ansible Documentation Sep 20, 2018
@acozine acozine moved this from Backport to 2.6 to Done in OLD Ansible Documentation Nov 6, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

@acozine acozine Awaiting requested review from acozine

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 docs This issue/PR relates to or includes documentation. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
Contributor Experience
  
Done
Contributor Experience
  
Done
OLD Ansible Documentation
  
Done
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dagwieers @ansibot @gundalow @acozine