service_facts: Use LANG=C to run commands

[tyll]

SUMMARY

This allows to parse the output when the user's locale changes the
commands' output. For example chkconfig uses 'Ein' and 'Aus' instead of
'on' and 'off' when using LANG=de_DE.UTF-8 breaking the service
detection on RHEL 6.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

service_facts

ANSIBLE VERSION

ansible 2.7.0.dev0 (service_facts_LANG_C be6a1236ad) last updated 2018/08/21 18:47:36 (GMT +200)
  config file = /home/till/.ansible.cfg
  configured module search path = [u'/home/till/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/till/scm/gh-ansible-ansible/lib/ansible
  executable location = /home/till/scm/gh-ansible-ansible/bin/ansible
  python version = 2.7.15 (default, May 16 2018, 17:50:09) [GCC 8.1.1 20180502 (Red Hat 8.1.1-1)]

ansible 2.6.1
  config file = /home/till/.ansible.cfg
  configured module search path = [u'/home/till/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.15 (default, May 16 2018, 17:50:09) [GCC 8.1.1 20180502 (Red Hat 8.1.1-1)]

ansible 2.6.2
  config file = /home/till/.ansible.cfg
  configured module search path = [u'/home/till/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.15 (default, May 16 2018, 17:50:09) [GCC 8.1.1 20180502 (Red Hat 8.1.1-1)]

ADDITIONAL INFORMATION

# before
ansible -m service_facts -i rhel6-cloud, all
rhel6-cloud | SKIPPED

# after
ansible -i rhel6-cloud,  -m service_facts all
rhel6-cloud | SUCCESS => {
    "ansible_facts": {
        "services": {
            "acpid": {
                "name": "acpid", 
                "source": "sysv", 
                "state": "running"
            }, 
[...]
            "udev-post": {
                "name": "udev-post", 
                "source": "sysv", 
                "state": "running"
            }
        }
    }, 
    "changed": false
}

[ansibot]

cc @maxamillion
click here for bot help

[ansibot]

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/modules/system/service_facts.py:94:161: E501 line too long (173 > 160 characters)
lib/ansible/modules/system/service_facts.py:155:161: E501 line too long (161 > 160 characters)
lib/ansible/modules/system/service_facts.py:192:161: E501 line too long (164 > 160 characters)

click here for bot help

[tyll]

ready_for_review

[bcoca]

instead of updating each command just set run_command_environ_update

[tyll]

Thx, I changed this and also added LC_ALL to the override. When I understand man 7 locale correctly, only setting LC_ALL should suffice since it has the highest priority.

[bcoca]

man page says that .. but not all programs obey that, though i think all the ones related to services do.

[tyll]

ready_for_review