Add SSL support to postgresql_schema module #44482

andytom · 2018-08-21T19:20:56Z

SUMMARY

Have added some extra arguments to the postgresql_schema module to allow
configuring an SSL connection to the postgresql server. The arguments
and method used here for the connection are the same as used by the
postgresql_database module.

Related to #39906

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

postgresql_schema

ANSIBLE VERSION

2.5.0

ADDITIONAL INFORMATION

You can now use the same ssl configuration arguments as the postgresql_database module for the postgresql_schema module. For example:

- name: Ensure bob owns the acme schema
  postgresql_schema:
    login_host: psql.example.com
    login_user: example_user
    login_password: super-secret-password
    ssl_rootcert: /path/to/ssl/cert
    ssl_mode: verify-full

    database: example_db
    name: acme
    owner: bob

andytom · 2018-08-21T19:26:21Z

lib/ansible/modules/database/postgresql/postgresql_schema.py

    try:
-        db_connection = psycopg2.connect(database=database, **kw)
+        db_connection = psycopg2.connect(**kw)
        # Enable autocommit so we can create databases
        if psycopg2.__version__ >= '2.4.2':


I'm not sure if enabling auto-commit is required for this module.

ansibot · 2018-08-21T19:29:17Z

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/database/postgresql/postgresql_schema.py:239:42: undefined-variable Undefined variable 'sslrootcert'

click here for bot help

ansibot · 2018-08-28T13:06:38Z

cc @matburt
click here for bot help

andytom · 2018-09-09T12:50:51Z

@matburt, would it be possible to get a quick review of this and let me know if there is anything that I need to change?

Dorn- · 2018-10-02T08:11:38Z

sgtm 👍

andytom · 2018-10-02T10:49:34Z

sgtm 👍

@Dorn- I think you need to comment shipit for the bot to count an approval (https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md#cmd-shipit).

Dorn- · 2018-10-02T14:41:05Z

I don't think that I am a maintainer, but let's try it :)

Dorn- · 2018-10-02T14:41:09Z

shipit

andytom · 2018-10-02T14:45:25Z

bot_status

ansibot · 2018-10-02T14:49:48Z

Components

lib/ansible/modules/database/postgresql/postgresql_schema.py
support: community
maintainers: matburt

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 1
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): Dorn-
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

andytom · 2018-10-02T14:54:31Z

I don't think that I am a maintainer, but let's try it :)

@Dorn-, I assumed you were the maintainer because you are the author in the module docs, oh well.

@matburt, I think this is just waiting on you now.

andytom · 2018-10-29T15:41:47Z

ready_for_review

andytom · 2018-10-30T10:09:59Z

+label affects_2.8
-label affects_2.7

Have added some extra arguments to the postgresql_schema module to allow configuring an SSL connection to the postgresql server. The arguments and method used here for the connection are the same as used by the postgresql_database module.

andytom commented Aug 21, 2018

View reviewed changes

andytom force-pushed the feature/postgresql_schema_ssl branch from 3e3dabf to 05e232f Compare August 21, 2018 19:33

ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 21, 2018

jborean93 removed the needs_triage Needs a first human triage before being processed. label Aug 23, 2018

ansibot removed the needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) label Aug 28, 2018

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 5, 2018

andytom closed this Sep 5, 2018

andytom reopened this Sep 5, 2018

ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 5, 2018

andytom force-pushed the feature/postgresql_schema_ssl branch from 05e232f to 117d25a Compare September 5, 2018 19:56

andytom force-pushed the feature/postgresql_schema_ssl branch from 117d25a to 867b5f9 Compare September 9, 2018 15:13

andytom force-pushed the feature/postgresql_schema_ssl branch from 867b5f9 to 307cfdd Compare September 16, 2018 16:51

ansibot added the support:community This issue/PR relates to code supported by the Ansible community. label Oct 2, 2018

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 10, 2018

andytom force-pushed the feature/postgresql_schema_ssl branch from a89ced4 to 03798ed Compare October 11, 2018 10:52

ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 11, 2018

andytom force-pushed the feature/postgresql_schema_ssl branch from 03798ed to b2ac90c Compare October 19, 2018 16:19

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 29, 2018

andytom force-pushed the feature/postgresql_schema_ssl branch from b2ac90c to 1fd32e9 Compare October 29, 2018 09:16

ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 29, 2018

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 7, 2018

Add SSL support to postgresql_schema module

1e4b987

Have added some extra arguments to the postgresql_schema module to allow configuring an SSL connection to the postgresql server. The arguments and method used here for the connection are the same as used by the postgresql_database module.

andytom force-pushed the feature/postgresql_schema_ssl branch from 1fd32e9 to 1e4b987 Compare November 8, 2018 09:12

ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 8, 2018

caphrim007 merged commit 0db06b9 into ansible:devel Nov 10, 2018

andytom deleted the feature/postgresql_schema_ssl branch November 11, 2018 10:35

andytom mentioned this pull request Nov 11, 2018

Add support for ssl connections to remaining postgresql modules #39906

Closed

dagwieers added postgresql PostgreSQL community database Database category labels Feb 7, 2019

ansible locked and limited conversation to collaborators Jul 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add SSL support to postgresql_schema module #44482

Add SSL support to postgresql_schema module #44482

andytom commented Aug 21, 2018 •

edited

andytom Aug 21, 2018

ansibot commented Aug 21, 2018

ansibot commented Aug 28, 2018

andytom commented Sep 9, 2018

Dorn- commented Oct 2, 2018

andytom commented Oct 2, 2018 •

edited

Dorn- commented Oct 2, 2018

Dorn- commented Oct 2, 2018

andytom commented Oct 2, 2018

ansibot commented Oct 2, 2018

andytom commented Oct 2, 2018 •

edited

andytom commented Oct 29, 2018

andytom commented Oct 30, 2018

Add SSL support to postgresql_schema module #44482

Add SSL support to postgresql_schema module #44482

Conversation

andytom commented Aug 21, 2018 • edited

SUMMARY

ISSUE TYPE

COMPONENT NAME

ANSIBLE VERSION

ADDITIONAL INFORMATION

andytom Aug 21, 2018

Choose a reason for hiding this comment

ansibot commented Aug 21, 2018

ansibot commented Aug 28, 2018

andytom commented Sep 9, 2018

Dorn- commented Oct 2, 2018

andytom commented Oct 2, 2018 • edited

Dorn- commented Oct 2, 2018

Dorn- commented Oct 2, 2018

andytom commented Oct 2, 2018

ansibot commented Oct 2, 2018

Components

Metadata

andytom commented Oct 2, 2018 • edited

andytom commented Oct 29, 2018

andytom commented Oct 30, 2018

andytom commented Aug 21, 2018 •

edited

andytom commented Oct 2, 2018 •

edited

andytom commented Oct 2, 2018 •

edited