Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct string in unit tests #44488

Merged

Conversation

caphrim007
Copy link
Contributor

SUMMARY

Just a simple cleanup. nothing important.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

bigip modules

ANSIBLE VERSION
ansible 2.7.0.dev0
  config file = None
  configured module search path = ['/root/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python3.6/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 3.6.6 (default, Jul 17 2018, 11:12:33) [GCC 6.3.0 20170516]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Aug 21, 2018

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. networking Network category python3 support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Aug 21, 2018
@caphrim007 caphrim007 force-pushed the bugfix.correct-string-in-f5-unit-tests branch from 4e4a7c2 to ce1fa4d Compare August 21, 2018 22:56
@caphrim007 caphrim007 removed the needs_triage Needs a first human triage before being processed. label Aug 21, 2018
@ansibot ansibot added f5 module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. labels Aug 21, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 21, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 5 errors:

lib/ansible/modules/network/f5/bigip_profile_dns.py:0:0: E309 version_added for new option (cache_name) should be 2.7. Currently 0.0
lib/ansible/modules/network/f5/bigip_profile_dns.py:0:0: E309 version_added for new option (enable_dns_cache) should be 2.7. Currently 0.0
lib/ansible/modules/network/f5/bigip_profile_dns.py:0:0: E322 "enable_cache" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/network/f5/bigip_profile_dns.py:0:0: E323 "enable_dns_cache" is listed in DOCUMENTATION.options, but not accepted by the module
lib/ansible/modules/network/f5/bigip_profile_dns.py:0:0: E325 argument_spec for "enable_cache" defines type="bool" but documentation does not

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Aug 21, 2018
Cleanup of unit tests. Modules fixes in iapp_template nad profile_dns
to support unit tests.
@caphrim007 caphrim007 force-pushed the bugfix.correct-string-in-f5-unit-tests branch from ce1fa4d to 0aa9667 Compare August 22, 2018 01:12
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 22, 2018
@caphrim007 caphrim007 merged commit 49f34fe into ansible:devel Aug 22, 2018
@caphrim007 caphrim007 deleted the bugfix.correct-string-in-f5-unit-tests branch August 28, 2018 17:10
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. f5 module This issue/PR relates to a module. networking Network category python3 support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants