Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct vault example #44507

Merged
merged 2 commits into from
Aug 22, 2018
Merged

correct vault example #44507

merged 2 commits into from
Aug 22, 2018

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Aug 22, 2018

SUMMARY

fixes #43897

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

docs

ANSIBLE VERSION
2.x

@ansibot
Copy link
Contributor

ansibot commented Aug 22, 2018

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 22, 2018
3837646266663835640a313164343535316666653031353763613037656362613535633538386539
65656439626166666363323435613131643066353762333232326232323565376635
...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line above this says:
Copy this output into your inventory file under [vyos:vars], which now looks like this:

But the updated example doesn't seem to use [vyos:vars] anymore? Should that sentence be updated as well to show the new structure?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed the text and added more about INI and inlined vaults, also corrected some code block formatting

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Aug 22, 2018
@samccann samccann merged commit 57293b3 into ansible:devel Aug 22, 2018
@bcoca bcoca deleted the ini_no_vault branch August 22, 2018 15:00
@samccann samccann added this to Docsite work in Ansible-maintained Collections Documentation via automation Aug 22, 2018
@samccann samccann moved this from Docsite work to Needs Backport to 2.6 in Ansible-maintained Collections Documentation Aug 22, 2018
samccann pushed a commit to samccann/ansible that referenced this pull request Aug 22, 2018
* correct vault example

fixes ansible#43897

* corrected text and code blocks

(cherry picked from commit 57293b3)
@samccann samccann moved this from Needs Backport to 2.6 to Done in Ansible-maintained Collections Documentation Aug 22, 2018
rcarrillocruz pushed a commit that referenced this pull request Aug 23, 2018
* correct vault example

fixes #43897

* corrected text and code blocks

(cherry picked from commit 57293b3)
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. docs This issue/PR relates to or includes documentation. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Misleading documentation, it shows that you can store vaulted passwords in INI files but it does not work
3 participants