Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

botmeta: scaleway isn't core #44511

Merged
merged 1 commit into from
Aug 23, 2018
Merged

botmeta: scaleway isn't core #44511

merged 1 commit into from
Aug 23, 2018

Conversation

pilou-
Copy link
Contributor

@pilou- pilou- commented Aug 22, 2018

SUMMARY

scaleway isn't core: update support keyword for scaleway module_utils and inventory plugin.

cc @sieben

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

.github/BOTMETA.yml

ANSIBLE VERSION
ansible 2.7.0.dev0 (devel 613a53c114) last updated 2018/08/22 16:51:02 (GMT +200)

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 22, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Aug 23, 2018
jborean93
jborean93 reviewed Aug 23, 2018
View reviewed changes
Copy link
Contributor

@jborean93 jborean93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we want to move to use anchors in the botmeta? @gundalow do you have any thoughts on this?

@gundalow
Copy link
Contributor

Hum, we don't use anchors else where, though it does make it much easier to maintain.

@gundalow gundalow merged commit 9e072c7 into ansible:devel Aug 23, 2018
@dagwieers dagwieers added the botmeta This PR modifies the BOTMETA.yml and this requires special attention! label Feb 21, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jborean93 jborean93 jborean93 left review comments

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 botmeta This PR modifies the BOTMETA.yml and this requires special attention! bug This issue/PR relates to a bug. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pilou- @gundalow @jborean93 @dagwieers @ansibot