Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACME: improve tests (new Pebble version, strict mode) #44518

Merged
merged 2 commits into from
Aug 22, 2018
Merged

ACME: improve tests (new Pebble version, strict mode) #44518

merged 2 commits into from
Aug 22, 2018

Conversation

felixfontein
Copy link
Contributor

SUMMARY

This updates the ACME tests to use the newest ACME test container (see ansible/acme-test-container#8). It includes some new Pebble features (authz deactivation, key rollover support, support for new TLS-ALPN-01 draft) and enables Pebble's strict mode.

ISSUE TYPE
  • Feature Pull Request

(There should be a category "Test Pull Request" :) )

COMPONENT NAME

test/runner/lib/cloud/acme.py
acme_account

ANSIBLE VERSION
2.7.0

@ansibot
Copy link
Contributor

ansibot commented Aug 22, 2018

cc @Spredzy @mattclay @resmo
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Aug 22, 2018
resmo
resmo approved these changes Aug 22, 2018
View reviewed changes
Copy link
Contributor

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed needs_triage Needs a first human triage before being processed. labels Aug 22, 2018
@felixfontein
Copy link
Contributor Author

@resmo would you mind using your super-powers to get this merged? I need this to properly continue with #43756 ;-)

@resmo resmo merged commit ad0d10d into ansible:devel Aug 22, 2018
@resmo
Copy link
Contributor

resmo commented Aug 22, 2018

well done felix, enjoying merging your works ;)

@felixfontein
Copy link
Contributor Author

@resmo thanks :) I always hope not to introduce something stupid in them ;)

@felixfontein felixfontein deleted the acme-improve-tests branch August 22, 2018 20:19
@dagwieers dagwieers added the crypto Crypto community (ACME, openssl, letsencrypt) label Feb 7, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 crypto Crypto community (ACME, openssl, letsencrypt) feature This issue/PR relates to a feature request. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@felixfontein @ansibot @resmo @dagwieers