Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace invalid_params with ValueError #44545

Merged
merged 1 commit into from
Aug 23, 2018
Merged

Replace invalid_params with ValueError #44545

merged 1 commit into from
Aug 23, 2018

Conversation

LindsayHill
Copy link
Contributor

SUMMARY

Extreme networking modules returned self.invalid_params - this was not valid, and the new pattern is to use raise ValueError() - see #43643

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/cliconf/exos.py
plugins/cliconf/ironware.py
plugins/cliconf/nos.py
plugins/cliconf/slxos.py
plugins/cliconf/voss.py

ANSIBLE VERSION
ansible 2.7.0.dev0 (invalid_params 98115727e8) last updated 2018/08/22 16:35:18 (GMT -700)
  config file = /Users/lhill/github/ansible-extreme/slxos/playbooks/ansible.cfg
  configured module search path = [u'/Users/lhill/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/lhill/github/ansible/lib/ansible
  executable location = /Users/lhill/github/ansible/bin/ansible
  python version = 2.7.10 (default, Oct  6 2017, 22:29:07) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.31)]
ADDITIONAL INFORMATION

Also fixes pylint warning E: 57,19: Instance of 'Cliconf' has no 'invalid_params' member (no-member)

@ansibot
Copy link
Contributor

ansibot commented Aug 22, 2018

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 22, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Aug 23, 2018
@rcarrillocruz rcarrillocruz merged commit 6c05e03 into ansible:devel Aug 23, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants