Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firewalld: Add bool Type To permanent In Docs #44579

Merged
merged 1 commit into from
Aug 23, 2018
Merged

Firewalld: Add bool Type To permanent In Docs #44579

merged 1 commit into from
Aug 23, 2018

Conversation

amayer5125
Copy link
Contributor

SUMMARY

Firewalld docs were missing type on permanent.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

firewalld

ANSIBLE VERSION
ansible 2.6.2
  config file = /etc/ansible/ansible.cfg
  configured module search path = ['/root/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python3.7/site-packages/ansible
  executable location = /usr/sbin/ansible
  python version = 3.7.0 (default, Jul 15 2018, 10:44:58) [GCC 8.1.1 20180531]

@ansibot
Copy link
Contributor

ansibot commented Aug 23, 2018

cc @maxamillion
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. python3 small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Aug 23, 2018
@maxamillion
Copy link
Contributor

rebuild_merge

@maxamillion maxamillion removed docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. python3 labels Aug 23, 2018
@maxamillion maxamillion self-assigned this Aug 23, 2018
@ansibot ansibot merged commit 4002be6 into ansible:devel Aug 23, 2018
@amayer5125 amayer5125 deleted the firewalld-cleanup branch August 23, 2018 18:09
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maxamillion maxamillion maxamillion approved these changes

Assignees

@maxamillion maxamillion

Labels
affects_2.7 This issue/PR affects Ansible v2.7 community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amayer5125 @ansibot @maxamillion